undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40b1e1ec58
git-commit-vandalism/contrib/subtree
History
Luke Shumaker 40b1e1ec58 subtree: t7900: comment subtree_test_create_repo 
It's unclear what the purpose of t7900-subtree.sh's
`subtree_test_create_repo` helper function is.  It wraps test-lib.sh's,
`test_create_repo` but follows that up by setting log.date=relative.  Why
does it set log.date=relative?

My first guess was that at one point the tests required that, but no
longer do, and that the function is now vestigial.  I even wrote a patch
to get rid of it and was moments away from `git send-email`ing it.

However, by chance when looking for something else in the history, I
discovered the true reason, from e7aac44ed2 (contrib/subtree: ignore
log.date configuration, 2015-07-21).  It's testing that setting
log.date=relative doesn't break `git subtree`, as at one point in the past
that did break `git subtree`.

So, add a comment about this, to avoid future such confusion.

And while at it, go ahead and (1) touch up the function to avoid a
pointless subshell and (2) update the one test that didn't use it.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-04-28 16:47:16 +09:00
..
t subtree: t7900: comment subtree_test_create_repo 2021-04-28 16:47:16 +09:00
.gitignore
COPYING
git-subtree.sh contrib/subtree: ensure only one rev is provided 2019-03-12 17:38:03 +09:00
git-subtree.txt contrib/subtree: document 'push' does not take '--squash' 2020-08-18 12:12:29 -07:00
INSTALL
Makefile subtree: fix build with AsciiDoctor 2 2020-04-08 12:10:36 -07:00
README
todo contrib/subtree: remove "push" command from the "todo" file 2015-11-06 09:32:33 -08:00

README 

Please read git-subtree.txt for documentation.

Please don't contact me using github mail; it's slow, ugly, and worst of
all, redundant. Email me instead at apenwarr@gmail.com and I'll be happy to
help.

Avery