
llist_merge() has special inner loops for taking elements from either of the two lists to merge. That helps consistently preferring one over the other, for stability. Merge the loops, swap the lists when the other one has the next element for the result and keep track on which one to prefer on equality. This results in shorter code and object text: Before: __TEXT __DATA __OBJC others dec hex 412 0 0 3441 3853 f0d mergesort.o With this patch: __TEXT __DATA __OBJC others dec hex 352 0 0 3516 3868 f1c mergesort.o Performance doesn't get worse: Before: 0071.12: llist_mergesort() unsorted 0.24(0.22+0.01) 0071.14: llist_mergesort() sorted 0.12(0.10+0.01) 0071.16: llist_mergesort() reversed 0.12(0.10+0.01) Benchmark 1: t/helper/test-tool mergesort test Time (mean ± σ): 109.2 ms ± 0.2 ms [User: 107.5 ms, System: 1.1 ms] Range (min … max): 108.9 ms … 109.6 ms 27 runs With this patch: 0071.12: llist_mergesort() unsorted 0.24(0.22+0.01) 0071.14: llist_mergesort() sorted 0.12(0.10+0.01) 0071.16: llist_mergesort() reversed 0.12(0.10+0.01) Benchmark 1: t/helper/test-tool mergesort test Time (mean ± σ): 108.4 ms ± 0.2 ms [User: 106.7 ms, System: 1.2 ms] Range (min … max): 108.0 ms … 108.8 ms 27 runs Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
77 lines
1.8 KiB
C
77 lines
1.8 KiB
C
#include "cache.h"
|
|
#include "mergesort.h"
|
|
|
|
/* Combine two sorted lists. Take from `list` on equality. */
|
|
static void *llist_merge(void *list, void *other,
|
|
void *(*get_next_fn)(const void *),
|
|
void (*set_next_fn)(void *, void *),
|
|
int (*compare_fn)(const void *, const void *))
|
|
{
|
|
void *result = list, *tail;
|
|
int prefer_list = compare_fn(list, other) <= 0;
|
|
|
|
if (!prefer_list) {
|
|
result = other;
|
|
SWAP(list, other);
|
|
}
|
|
for (;;) {
|
|
do {
|
|
tail = list;
|
|
list = get_next_fn(list);
|
|
if (!list) {
|
|
set_next_fn(tail, other);
|
|
return result;
|
|
}
|
|
} while (compare_fn(list, other) < prefer_list);
|
|
set_next_fn(tail, other);
|
|
prefer_list ^= 1;
|
|
SWAP(list, other);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Perform an iterative mergesort using an array of sublists.
|
|
*
|
|
* n is the number of items.
|
|
* ranks[i] is undefined if n & 2^i == 0, and assumed empty.
|
|
* ranks[i] contains a sublist of length 2^i otherwise.
|
|
*
|
|
* The number of bits in a void pointer limits the number of objects
|
|
* that can be created, and thus the number of array elements necessary
|
|
* to be able to sort any valid list.
|
|
*
|
|
* Adding an item to this array is like incrementing a binary number;
|
|
* positional values for set bits correspond to sublist lengths.
|
|
*/
|
|
void *llist_mergesort(void *list,
|
|
void *(*get_next_fn)(const void *),
|
|
void (*set_next_fn)(void *, void *),
|
|
int (*compare_fn)(const void *, const void *))
|
|
{
|
|
void *ranks[bitsizeof(void *)];
|
|
size_t n = 0;
|
|
|
|
if (!list)
|
|
return NULL;
|
|
|
|
for (;;) {
|
|
int i;
|
|
size_t m;
|
|
void *next = get_next_fn(list);
|
|
if (next)
|
|
set_next_fn(list, NULL);
|
|
for (i = 0, m = n;; i++, m >>= 1) {
|
|
if (m & 1)
|
|
list = llist_merge(ranks[i], list, get_next_fn,
|
|
set_next_fn, compare_fn);
|
|
else if (next)
|
|
break;
|
|
else if (!m)
|
|
return list;
|
|
}
|
|
n++;
|
|
ranks[i] = list;
|
|
list = next;
|
|
}
|
|
}
|