e75d2f7f73
Extend the the release_revisions() function so that it frees the "filter" in the "struct rev_info". This in combination with a preceding change to free "cmdline" means that we can mark another set of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true". The "filter" member was added recently inffaa137f64(revision: put object filter into struct rev_info, 2022-03-09), and this fixes leaks intruded in the subsequent leak7940941de1(pack-objects: use rev.filter when possible, 2022-03-09) and105c6f14ad(bundle: parse filter capability, 2022-03-09). The "builtin/pack-objects.c" leak in7940941de1was effectively with us already, but the variable was referred to by a "static" file-scoped variable. The "bundle.c " leak in105c6f14adwas newly introduced with the new "filter" feature for bundles. The "t5600-clone-fail-cleanup.sh" change here to add "TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where run-command.c in not carrying the abort() exit code upwards would have had that test passing before, but now it *actually* passes[1]. We should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual leaks some other time, but it's an existing edge case, let's just mark the really-passing test as passing for now. 1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
103 lines
1.8 KiB
Bash
Executable File
103 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='selecting remote repo in ambiguous cases'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
reset() {
|
|
rm -rf foo foo.git fetch clone
|
|
}
|
|
|
|
make_tree() {
|
|
git init "$1" &&
|
|
(cd "$1" && test_commit "$1")
|
|
}
|
|
|
|
make_bare() {
|
|
git init --bare "$1" &&
|
|
(cd "$1" &&
|
|
tree=$(git hash-object -w -t tree /dev/null) &&
|
|
commit=$(echo "$1" | git commit-tree $tree) &&
|
|
git update-ref HEAD $commit
|
|
)
|
|
}
|
|
|
|
get() {
|
|
git init --bare fetch &&
|
|
(cd fetch && git fetch "../$1") &&
|
|
git clone "$1" clone
|
|
}
|
|
|
|
check() {
|
|
echo "$1" >expect &&
|
|
(cd fetch && git log -1 --format=%s FETCH_HEAD) >actual.fetch &&
|
|
(cd clone && git log -1 --format=%s HEAD) >actual.clone &&
|
|
test_cmp expect actual.fetch &&
|
|
test_cmp expect actual.clone
|
|
}
|
|
|
|
test_expect_success 'find .git dir in worktree' '
|
|
reset &&
|
|
make_tree foo &&
|
|
get foo &&
|
|
check foo
|
|
'
|
|
|
|
test_expect_success 'automagically add .git suffix' '
|
|
reset &&
|
|
make_bare foo.git &&
|
|
get foo &&
|
|
check foo.git
|
|
'
|
|
|
|
test_expect_success 'automagically add .git suffix to worktree' '
|
|
reset &&
|
|
make_tree foo.git &&
|
|
get foo &&
|
|
check foo.git
|
|
'
|
|
|
|
test_expect_success 'prefer worktree foo over bare foo.git' '
|
|
reset &&
|
|
make_tree foo &&
|
|
make_bare foo.git &&
|
|
get foo &&
|
|
check foo
|
|
'
|
|
|
|
test_expect_success 'prefer bare foo over bare foo.git' '
|
|
reset &&
|
|
make_bare foo &&
|
|
make_bare foo.git &&
|
|
get foo &&
|
|
check foo
|
|
'
|
|
|
|
test_expect_success 'disambiguate with full foo.git' '
|
|
reset &&
|
|
make_bare foo &&
|
|
make_bare foo.git &&
|
|
get foo.git &&
|
|
check foo.git
|
|
'
|
|
|
|
test_expect_success 'we are not fooled by non-git foo directory' '
|
|
reset &&
|
|
make_bare foo.git &&
|
|
mkdir foo &&
|
|
get foo &&
|
|
check foo.git
|
|
'
|
|
|
|
test_expect_success 'prefer inner .git over outer bare' '
|
|
reset &&
|
|
make_tree foo &&
|
|
make_bare foo.git &&
|
|
mv foo/.git foo.git &&
|
|
get foo.git &&
|
|
check foo
|
|
'
|
|
|
|
test_done
|