6b2fbaaffc
This patch makes two small changes to improve the output of --inline and --attach. The first is to write a newline preceding the boundary. This is needed because MIME defines the encapsulation boundary as including the preceding CRLF (or in this case, just LF), so we should be writing one. Without this, the last newline in the pre-diff content is consumed instead. The second change is to always write the line termination character (default: newline) even when using --inline or --attach. This is simply to improve the aesthetics of the resulting message. When using --inline an email client should render the resulting message identically to the non-inline version. And when using --attach this adds a blank line preceding the attachment in the email, which is visually attractive. Signed-off-by: Kevin Ballard <kevin@sb.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
171 lines
3.5 KiB
Plaintext
171 lines
3.5 KiB
Plaintext
$ git format-patch --attach --stdout initial..master
|
|
From 1bde4ae5f36c8d9abe3a0fce0c6aab3c4a12fe44 Mon Sep 17 00:00:00 2001
|
|
From: A U Thor <author@example.com>
|
|
Date: Mon, 26 Jun 2006 00:01:00 +0000
|
|
Subject: [PATCH] Second
|
|
MIME-Version: 1.0
|
|
Content-Type: multipart/mixed; boundary="------------g-i-t--v-e-r-s-i-o-n"
|
|
|
|
This is a multi-part message in MIME format.
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/plain; charset=UTF-8; format=fixed
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
|
|
This is the second commit.
|
|
---
|
|
dir/sub | 2 ++
|
|
file0 | 3 +++
|
|
file2 | 3 ---
|
|
3 files changed, 5 insertions(+), 3 deletions(-)
|
|
delete mode 100644 file2
|
|
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/x-patch; name="1bde4ae5f36c8d9abe3a0fce0c6aab3c4a12fe44.diff"
|
|
Content-Transfer-Encoding: 8bit
|
|
Content-Disposition: attachment; filename="1bde4ae5f36c8d9abe3a0fce0c6aab3c4a12fe44.diff"
|
|
|
|
diff --git a/dir/sub b/dir/sub
|
|
index 35d242b..8422d40 100644
|
|
--- a/dir/sub
|
|
+++ b/dir/sub
|
|
@@ -1,2 +1,4 @@
|
|
A
|
|
B
|
|
+C
|
|
+D
|
|
diff --git a/file0 b/file0
|
|
index 01e79c3..b414108 100644
|
|
--- a/file0
|
|
+++ b/file0
|
|
@@ -1,3 +1,6 @@
|
|
1
|
|
2
|
|
3
|
|
+4
|
|
+5
|
|
+6
|
|
diff --git a/file2 b/file2
|
|
deleted file mode 100644
|
|
index 01e79c3..0000000
|
|
--- a/file2
|
|
+++ /dev/null
|
|
@@ -1,3 +0,0 @@
|
|
-1
|
|
-2
|
|
-3
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n--
|
|
|
|
|
|
|
|
From 9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0 Mon Sep 17 00:00:00 2001
|
|
From: A U Thor <author@example.com>
|
|
Date: Mon, 26 Jun 2006 00:02:00 +0000
|
|
Subject: [PATCH] Third
|
|
MIME-Version: 1.0
|
|
Content-Type: multipart/mixed; boundary="------------g-i-t--v-e-r-s-i-o-n"
|
|
|
|
This is a multi-part message in MIME format.
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/plain; charset=UTF-8; format=fixed
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
---
|
|
dir/sub | 2 ++
|
|
file1 | 3 +++
|
|
2 files changed, 5 insertions(+), 0 deletions(-)
|
|
create mode 100644 file1
|
|
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/x-patch; name="9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0.diff"
|
|
Content-Transfer-Encoding: 8bit
|
|
Content-Disposition: attachment; filename="9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0.diff"
|
|
|
|
diff --git a/dir/sub b/dir/sub
|
|
index 8422d40..cead32e 100644
|
|
--- a/dir/sub
|
|
+++ b/dir/sub
|
|
@@ -2,3 +2,5 @@ A
|
|
B
|
|
C
|
|
D
|
|
+E
|
|
+F
|
|
diff --git a/file1 b/file1
|
|
new file mode 100644
|
|
index 0000000..b1e6722
|
|
--- /dev/null
|
|
+++ b/file1
|
|
@@ -0,0 +1,3 @@
|
|
+A
|
|
+B
|
|
+C
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n--
|
|
|
|
|
|
|
|
From c7a2ab9e8eac7b117442a607d5a9b3950ae34d5a Mon Sep 17 00:00:00 2001
|
|
From: A U Thor <author@example.com>
|
|
Date: Mon, 26 Jun 2006 00:03:00 +0000
|
|
Subject: [PATCH] Side
|
|
MIME-Version: 1.0
|
|
Content-Type: multipart/mixed; boundary="------------g-i-t--v-e-r-s-i-o-n"
|
|
|
|
This is a multi-part message in MIME format.
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/plain; charset=UTF-8; format=fixed
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
---
|
|
dir/sub | 2 ++
|
|
file0 | 3 +++
|
|
file3 | 4 ++++
|
|
3 files changed, 9 insertions(+), 0 deletions(-)
|
|
create mode 100644 file3
|
|
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n
|
|
Content-Type: text/x-patch; name="c7a2ab9e8eac7b117442a607d5a9b3950ae34d5a.diff"
|
|
Content-Transfer-Encoding: 8bit
|
|
Content-Disposition: attachment; filename="c7a2ab9e8eac7b117442a607d5a9b3950ae34d5a.diff"
|
|
|
|
diff --git a/dir/sub b/dir/sub
|
|
index 35d242b..7289e35 100644
|
|
--- a/dir/sub
|
|
+++ b/dir/sub
|
|
@@ -1,2 +1,4 @@
|
|
A
|
|
B
|
|
+1
|
|
+2
|
|
diff --git a/file0 b/file0
|
|
index 01e79c3..f4615da 100644
|
|
--- a/file0
|
|
+++ b/file0
|
|
@@ -1,3 +1,6 @@
|
|
1
|
|
2
|
|
3
|
|
+A
|
|
+B
|
|
+C
|
|
diff --git a/file3 b/file3
|
|
new file mode 100644
|
|
index 0000000..7289e35
|
|
--- /dev/null
|
|
+++ b/file3
|
|
@@ -0,0 +1,4 @@
|
|
+A
|
|
+B
|
|
+1
|
|
+2
|
|
|
|
--------------g-i-t--v-e-r-s-i-o-n--
|
|
|
|
|
|
$
|