7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
162 lines
3.0 KiB
Bash
Executable File
162 lines
3.0 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2009 Eric Wong
|
|
|
|
test_description='git svn creates empty directories'
|
|
|
|
TEST_FAILS_SANITIZE_LEAK=true
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'initialize repo' '
|
|
for i in a b c d d/e d/e/f "weird file name"
|
|
do
|
|
svn_cmd mkdir -m "mkdir $i" "$svnrepo"/"$i" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'clone' 'git svn clone "$svnrepo" cloned'
|
|
|
|
test_expect_success 'empty directories exist' '
|
|
(
|
|
cd cloned &&
|
|
for i in a b c d d/e d/e/f "weird file name"
|
|
do
|
|
if ! test -d "$i"
|
|
then
|
|
echo >&2 "$i does not exist" &&
|
|
exit 1
|
|
fi
|
|
done
|
|
)
|
|
'
|
|
|
|
test_expect_success 'option automkdirs set to false' '
|
|
(
|
|
git svn init "$svnrepo" cloned-no-mkdirs &&
|
|
cd cloned-no-mkdirs &&
|
|
git config svn-remote.svn.automkdirs false &&
|
|
git svn fetch &&
|
|
for i in a b c d d/e d/e/f "weird file name"
|
|
do
|
|
if test -d "$i"
|
|
then
|
|
echo >&2 "$i exists" &&
|
|
exit 1
|
|
fi
|
|
done
|
|
)
|
|
'
|
|
|
|
test_expect_success 'more emptiness' '
|
|
svn_cmd mkdir -m "bang bang" "$svnrepo"/"! !"
|
|
'
|
|
|
|
test_expect_success 'git svn rebase creates empty directory' '
|
|
( cd cloned && git svn rebase ) &&
|
|
test -d cloned/"! !"
|
|
'
|
|
|
|
test_expect_success 'git svn mkdirs recreates empty directories' '
|
|
(
|
|
cd cloned &&
|
|
rm -r * &&
|
|
git svn mkdirs &&
|
|
for i in a b c d d/e d/e/f "weird file name" "! !"
|
|
do
|
|
if ! test -d "$i"
|
|
then
|
|
echo >&2 "$i does not exist" &&
|
|
exit 1
|
|
fi
|
|
done
|
|
)
|
|
'
|
|
|
|
test_expect_success 'git svn mkdirs -r works' '
|
|
(
|
|
cd cloned &&
|
|
rm -r * &&
|
|
git svn mkdirs -r7 &&
|
|
for i in a b c d d/e d/e/f "weird file name"
|
|
do
|
|
if ! test -d "$i"
|
|
then
|
|
echo >&2 "$i does not exist" &&
|
|
exit 1
|
|
fi
|
|
done &&
|
|
|
|
if test -d "! !"
|
|
then
|
|
echo >&2 "$i should not exist" &&
|
|
exit 1
|
|
fi &&
|
|
|
|
git svn mkdirs -r8 &&
|
|
if ! test -d "! !"
|
|
then
|
|
echo >&2 "$i not exist" &&
|
|
exit 1
|
|
fi
|
|
)
|
|
'
|
|
|
|
test_expect_success 'initialize trunk' '
|
|
for i in trunk trunk/a trunk/"weird file name"
|
|
do
|
|
svn_cmd mkdir -m "mkdir $i" "$svnrepo"/"$i" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'clone trunk' 'git svn clone -s "$svnrepo" trunk'
|
|
|
|
test_expect_success 'empty directories in trunk exist' '
|
|
(
|
|
cd trunk &&
|
|
for i in a "weird file name"
|
|
do
|
|
if ! test -d "$i"
|
|
then
|
|
echo >&2 "$i does not exist" &&
|
|
exit 1
|
|
fi
|
|
done
|
|
)
|
|
'
|
|
|
|
test_expect_success 'remove a top-level directory from svn' '
|
|
svn_cmd rm -m "remove d" "$svnrepo"/d
|
|
'
|
|
|
|
test_expect_success 'removed top-level directory does not exist' '
|
|
git svn clone "$svnrepo" removed &&
|
|
test ! -e removed/d
|
|
|
|
'
|
|
unhandled=.git/svn/refs/remotes/git-svn/unhandled.log
|
|
test_expect_success 'git svn gc-ed files work' '
|
|
(
|
|
cd removed &&
|
|
git svn gc &&
|
|
: Compress::Zlib may not be available &&
|
|
if test -f "$unhandled".gz
|
|
then
|
|
svn_cmd mkdir -m gz "$svnrepo"/gz &&
|
|
git reset --hard $(git rev-list HEAD | tail -1) &&
|
|
git svn rebase &&
|
|
test -f "$unhandled".gz &&
|
|
test -f "$unhandled" &&
|
|
for i in a b c "weird file name" gz "! !"
|
|
do
|
|
if ! test -d "$i"
|
|
then
|
|
echo >&2 "$i does not exist" &&
|
|
exit 1
|
|
fi
|
|
done
|
|
fi
|
|
)
|
|
'
|
|
|
|
test_done
|