04a0e98515
Commit 7ba826290a (revision: add rev_input_given flag, 2017-08-02) added
a flag to rev_info to tell whether we got any revision arguments. As
explained there, this is necessary because some revision arguments may
not produce any pending traversal objects, but should still inhibit
default behaviors (e.g., a glob that matches nothing).
However, it only set the flag in the globbing code, but not for
revisions we get on the command-line or via stdin. This leads to two
problems:
- the command-line code keeps its own separate got_rev_arg flag; this
isn't wrong, but it's confusing and an extra maintenance burden
- even specifically-named rev arguments might end up not adding any
pending objects: if --ignore-missing is set, then specifying a
missing object is a noop rather than an error.
And that leads to some user-visible bugs:
- when deciding whether a default rev like "HEAD" should kick in, we
check both got_rev_arg and rev_input_given. That means that
"--ignore-missing $ZERO_OID" works on the command-line (where we set
got_rev_arg) but not on --stdin (where we don't)
- when rev-list decides whether it should complain that it wasn't
given a starting point, it relies on rev_input_given. So it can't
even get the command-line "--ignore-missing $ZERO_OID" right
Let's consistently set the flag if we got any revision argument. That
lets us clean up the redundant got_rev_arg, and fixes both of those bugs
(but note there are three new tests: we'll confirm the already working
git-log command-line case).
A few implementation notes:
- conceptually we want to set the flag whenever handle_revision_arg()
finds an actual revision arg ("handles" it, you might say). But it
covers a ton of cases with early returns. Rather than annotating
each one, we just wrap it and use its success exit-code to set the
flag in one spot.
- the new rev-list test is in t6018, which is titled to cover globs.
This isn't exactly a glob, but it made sense to stick it with the
other tests that handle the "even though we got a rev, we have no
pending objects" case, which are globs.
- the tests check for the oid of a missing object, which it's pretty
clear --ignore-missing should ignore. You can see the same behavior
with "--ignore-missing a-ref-that-does-not-exist", because
--ignore-missing treats them both the same. That's perhaps less
clearly correct, and we may want to change that in the future. But
the way the code and tests here are written, we'd continue to do the
right thing even if it does.
Reported-by: Bryan Turner <bturner@atlassian.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
386 lines
9.9 KiB
Bash
Executable File
386 lines
9.9 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='rev-list/rev-parse --glob'
|
|
|
|
. ./test-lib.sh
|
|
|
|
commit () {
|
|
test_tick &&
|
|
echo $1 > foo &&
|
|
git add foo &&
|
|
git commit -m "$1"
|
|
}
|
|
|
|
compare () {
|
|
# Split arguments on whitespace.
|
|
git $1 $2 >expected &&
|
|
git $1 $3 >actual &&
|
|
test_cmp expected actual
|
|
}
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
commit master &&
|
|
git checkout -b subspace/one master &&
|
|
commit one &&
|
|
git checkout -b subspace/two master &&
|
|
commit two &&
|
|
git checkout -b subspace-x master &&
|
|
commit subspace-x &&
|
|
git checkout -b other/three master &&
|
|
commit three &&
|
|
git checkout -b someref master &&
|
|
commit some &&
|
|
git checkout master &&
|
|
commit master2 &&
|
|
git tag foo/bar master &&
|
|
commit master3 &&
|
|
git update-ref refs/remotes/foo/baz master &&
|
|
commit master4 &&
|
|
git update-ref refs/remotes/upstream/one subspace/one &&
|
|
git update-ref refs/remotes/upstream/two subspace/two &&
|
|
git update-ref refs/remotes/upstream/x subspace-x &&
|
|
git tag qux/one subspace/one &&
|
|
git tag qux/two subspace/two &&
|
|
git tag qux/x subspace-x
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=refs/heads/subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=refs/heads/subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=refs/heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob=heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_failure 'rev-parse accepts --glob as detached option' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--glob heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_failure 'rev-parse is not confused by option-like glob' '
|
|
|
|
compare rev-parse "master" "--glob --symbolic master"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace/' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches=subspace' '
|
|
|
|
compare rev-parse "subspace/one subspace/two" "--branches=subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/subspace/* --glob=heads/other/*' '
|
|
|
|
compare rev-parse "subspace/one subspace/two other/three" "--glob=heads/subspace/* --glob=heads/other/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/someref/* master' '
|
|
|
|
compare rev-parse "master" "--glob=heads/someref/* master"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --glob=heads/*' '
|
|
|
|
compare rev-parse "master other/three someref subspace-x subspace/one subspace/two" "--glob=heads/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --tags=foo' '
|
|
|
|
compare rev-parse "foo/bar" "--tags=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --remotes=foo' '
|
|
|
|
compare rev-parse "foo/baz" "--remotes=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude with --branches' '
|
|
compare rev-parse "--exclude=*/* --branches" "master someref subspace-x"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude with --all' '
|
|
compare rev-parse "--exclude=refs/remotes/* --all" "--branches --tags"
|
|
'
|
|
|
|
test_expect_success 'rev-parse accumulates multiple --exclude' '
|
|
compare rev-parse "--exclude=refs/remotes/* --exclude=refs/tags/* --all" --branches
|
|
'
|
|
|
|
test_expect_success 'rev-parse --branches clears --exclude' '
|
|
compare rev-parse "--exclude=* --branches --branches" "--branches"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --tags clears --exclude' '
|
|
compare rev-parse "--exclude=* --tags --tags" "--tags"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --all clears --exclude' '
|
|
compare rev-parse "--exclude=* --all --all" "--all"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --branches=glob' '
|
|
compare rev-parse "--exclude=subspace-* --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --tags=glob' '
|
|
compare rev-parse "--exclude=qux/? --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=glob with --remotes=glob' '
|
|
compare rev-parse "--exclude=upstream/? --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --branches=glob' '
|
|
compare rev-parse "--exclude=subspace-x --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --tags=glob' '
|
|
compare rev-parse "--exclude=qux/x --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-parse --exclude=ref with --remotes=glob' '
|
|
compare rev-parse "--exclude=upstream/x --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --branches=glob' '
|
|
compare rev-list "--exclude=subspace-* --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --tags=glob' '
|
|
compare rev-list "--exclude=qux/? --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=glob with --remotes=glob' '
|
|
compare rev-list "--exclude=upstream/? --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --branches=glob' '
|
|
compare rev-list "--exclude=subspace-x --branches=sub*" "subspace/one subspace/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --tags=glob' '
|
|
compare rev-list "--exclude=qux/x --tags=qux/*" "qux/one qux/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude=ref with --remotes=glob' '
|
|
compare rev-list "--exclude=upstream/x --remotes=upstream/*" "upstream/one upstream/two"
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=refs/heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob refs/heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob refs/heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list not confused by option-like --glob arg' '
|
|
|
|
compare rev-list "master" "--glob -0 master"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=refs/heads/subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=refs/heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--glob=heads/subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace/' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace/"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches=subspace' '
|
|
|
|
compare rev-list "subspace/one subspace/two" "--branches=subspace"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --branches' '
|
|
|
|
compare rev-list "master subspace-x someref other/three subspace/one subspace/two" "--branches"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/someref/* master' '
|
|
|
|
compare rev-list "master" "--glob=heads/someref/* master"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/subspace/* --glob=heads/other/*' '
|
|
|
|
compare rev-list "subspace/one subspace/two other/three" "--glob=heads/subspace/* --glob=heads/other/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --glob=heads/*' '
|
|
|
|
compare rev-list "master other/three someref subspace-x subspace/one subspace/two" "--glob=heads/*"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --tags=foo' '
|
|
|
|
compare rev-list "foo/bar" "--tags=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --tags' '
|
|
|
|
compare rev-list "foo/bar qux/x qux/two qux/one" "--tags"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --remotes=foo' '
|
|
|
|
compare rev-list "foo/baz" "--remotes=foo"
|
|
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude with --branches' '
|
|
compare rev-list "--exclude=*/* --branches" "master someref subspace-x"
|
|
'
|
|
|
|
test_expect_success 'rev-list --exclude with --all' '
|
|
compare rev-list "--exclude=refs/remotes/* --all" "--branches --tags"
|
|
'
|
|
|
|
test_expect_success 'rev-list accumulates multiple --exclude' '
|
|
compare rev-list "--exclude=refs/remotes/* --exclude=refs/tags/* --all" --branches
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output on empty stdin' '
|
|
git rev-list --stdin </dev/null >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with all refs excluded' '
|
|
git rev-list --exclude=* --all >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with empty --all' '
|
|
(
|
|
test_create_repo empty &&
|
|
cd empty &&
|
|
git rev-list --all >actual &&
|
|
test_must_be_empty actual
|
|
)
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output with empty glob' '
|
|
git rev-list --glob=does-not-match-anything >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'rev-list should succeed with empty output when ignoring missing' '
|
|
git rev-list --ignore-missing $ZERO_OID >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'shortlog accepts --glob/--tags/--remotes' '
|
|
|
|
compare shortlog "subspace/one subspace/two" --branches=subspace &&
|
|
compare shortlog \
|
|
"master subspace-x someref other/three subspace/one subspace/two" \
|
|
--branches &&
|
|
compare shortlog master "--glob=heads/someref/* master" &&
|
|
compare shortlog "subspace/one subspace/two other/three" \
|
|
"--glob=heads/subspace/* --glob=heads/other/*" &&
|
|
compare shortlog \
|
|
"master other/three someref subspace-x subspace/one subspace/two" \
|
|
"--glob=heads/*" &&
|
|
compare shortlog foo/bar --tags=foo &&
|
|
compare shortlog "foo/bar qux/one qux/two qux/x" --tags &&
|
|
compare shortlog foo/baz --remotes=foo
|
|
|
|
'
|
|
|
|
test_expect_failure 'shortlog accepts --glob as detached option' '
|
|
|
|
compare shortlog \
|
|
"master other/three someref subspace-x subspace/one subspace/two" \
|
|
"--glob heads/*"
|
|
|
|
'
|
|
|
|
test_expect_failure 'shortlog --glob is not confused by option-like argument' '
|
|
|
|
compare shortlog master "--glob -e master"
|
|
|
|
'
|
|
|
|
test_done
|