7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
56 lines
1.8 KiB
Bash
Executable File
56 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007, 2009 Sam Vilain
|
|
#
|
|
|
|
test_description='git-svn svn mergeinfo properties'
|
|
|
|
TEST_FAILS_SANITIZE_LEAK=true
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'load svn dump' "
|
|
svnadmin load -q '$rawsvnrepo' \
|
|
<'$TEST_DIRECTORY/t9151/svn-mergeinfo.dump' &&
|
|
git svn init --minimize-url -R svnmerge \
|
|
--rewrite-root=http://svn.example.org \
|
|
-T trunk -b branches '$svnrepo' &&
|
|
git svn fetch --all
|
|
"
|
|
|
|
test_expect_success 'all svn merges became git merge commits' '
|
|
git rev-list --all --no-merges --grep=Merge >unmarked &&
|
|
test_must_be_empty unmarked
|
|
'
|
|
|
|
test_expect_success 'cherry picks did not become git merge commits' '
|
|
git rev-list --all --merges --grep=Cherry >bad-cherries &&
|
|
test_must_be_empty bad-cherries
|
|
'
|
|
|
|
test_expect_success 'svn non-merge merge commits did not become git merge commits' '
|
|
git rev-list --all --merges --grep=non-merge >bad-non-merges &&
|
|
test_must_be_empty bad-non-merges
|
|
'
|
|
|
|
test_expect_success 'commit made to merged branch is reachable from the merge' '
|
|
before_commit=$(git rev-list --all --grep="trunk commit before merging trunk to b2") &&
|
|
merge_commit=$(git rev-list --all --grep="Merge trunk to b2") &&
|
|
git rev-list -1 $before_commit --not $merge_commit >not-reachable &&
|
|
test_must_be_empty not-reachable
|
|
'
|
|
|
|
test_expect_success 'merging two branches in one commit is detected correctly' '
|
|
f1_commit=$(git rev-list --all --grep="make f1 branch from trunk") &&
|
|
f2_commit=$(git rev-list --all --grep="make f2 branch from trunk") &&
|
|
merge_commit=$(git rev-list --all --grep="Merge f1 and f2 to trunk") &&
|
|
git rev-list -1 $f1_commit $f2_commit --not $merge_commit >not-reachable &&
|
|
test_must_be_empty not-reachable
|
|
'
|
|
|
|
test_expect_failure 'everything got merged in the end' '
|
|
git rev-list --all --not main >unmerged &&
|
|
test_must_be_empty unmerged
|
|
'
|
|
|
|
test_done
|