7abcbcb7ea
The top-level &&-chain checker built into t/test-lib.sh causes tests to
magically exit with code 117 if the &&-chain is broken. However, it has
the shortcoming that the magic does not work within `{...}` groups,
`(...)` subshells, `$(...)` substitutions, or within bodies of compound
statements, such as `if`, `for`, `while`, `case`, etc. `chainlint.sed`
partly fills in the gap by catching broken &&-chains in `(...)`
subshells, but bugs can still lurk behind broken &&-chains in the other
cases.
Fix broken &&-chains in `{...}` groups in order to reduce the number of
possible lurking bugs.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
132 lines
2.3 KiB
Bash
Executable File
132 lines
2.3 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='check pre-push hooks'
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
. ./test-lib.sh
|
|
|
|
# Setup hook that always succeeds
|
|
HOOKDIR="$(git rev-parse --git-dir)/hooks"
|
|
HOOK="$HOOKDIR/pre-push"
|
|
mkdir -p "$HOOKDIR"
|
|
write_script "$HOOK" <<EOF
|
|
cat >/dev/null
|
|
exit 0
|
|
EOF
|
|
|
|
test_expect_success 'setup' '
|
|
git config push.default upstream &&
|
|
git init --bare repo1 &&
|
|
git remote add parent1 repo1 &&
|
|
test_commit one &&
|
|
git push parent1 HEAD:foreign
|
|
'
|
|
write_script "$HOOK" <<EOF
|
|
cat >/dev/null
|
|
exit 1
|
|
EOF
|
|
|
|
COMMIT1="$(git rev-parse HEAD)"
|
|
export COMMIT1
|
|
|
|
test_expect_success 'push with failing hook' '
|
|
test_commit two &&
|
|
test_must_fail git push parent1 HEAD
|
|
'
|
|
|
|
test_expect_success '--no-verify bypasses hook' '
|
|
git push --no-verify parent1 HEAD
|
|
'
|
|
|
|
COMMIT2="$(git rev-parse HEAD)"
|
|
export COMMIT2
|
|
|
|
write_script "$HOOK" <<'EOF'
|
|
echo "$1" >actual
|
|
echo "$2" >>actual
|
|
cat >>actual
|
|
EOF
|
|
|
|
cat >expected <<EOF
|
|
parent1
|
|
repo1
|
|
refs/heads/main $COMMIT2 refs/heads/foreign $COMMIT1
|
|
EOF
|
|
|
|
test_expect_success 'push with hook' '
|
|
git push parent1 main:foreign &&
|
|
diff expected actual
|
|
'
|
|
|
|
test_expect_success 'add a branch' '
|
|
git checkout -b other parent1/foreign &&
|
|
test_commit three
|
|
'
|
|
|
|
COMMIT3="$(git rev-parse HEAD)"
|
|
export COMMIT3
|
|
|
|
cat >expected <<EOF
|
|
parent1
|
|
repo1
|
|
refs/heads/other $COMMIT3 refs/heads/foreign $COMMIT2
|
|
EOF
|
|
|
|
test_expect_success 'push to default' '
|
|
git push &&
|
|
diff expected actual
|
|
'
|
|
|
|
cat >expected <<EOF
|
|
parent1
|
|
repo1
|
|
refs/tags/one $COMMIT1 refs/tags/tag1 $ZERO_OID
|
|
HEAD~ $COMMIT2 refs/heads/prev $ZERO_OID
|
|
EOF
|
|
|
|
test_expect_success 'push non-branches' '
|
|
git push parent1 one:tag1 HEAD~:refs/heads/prev &&
|
|
diff expected actual
|
|
'
|
|
|
|
cat >expected <<EOF
|
|
parent1
|
|
repo1
|
|
(delete) $ZERO_OID refs/heads/prev $COMMIT2
|
|
EOF
|
|
|
|
test_expect_success 'push delete' '
|
|
git push parent1 :prev &&
|
|
diff expected actual
|
|
'
|
|
|
|
cat >expected <<EOF
|
|
repo1
|
|
repo1
|
|
HEAD $COMMIT3 refs/heads/other $ZERO_OID
|
|
EOF
|
|
|
|
test_expect_success 'push to URL' '
|
|
git push repo1 HEAD &&
|
|
diff expected actual
|
|
'
|
|
|
|
test_expect_success 'set up many-ref tests' '
|
|
{
|
|
nr=1000 &&
|
|
while test $nr -lt 2000
|
|
do
|
|
nr=$(( $nr + 1 )) &&
|
|
echo "create refs/heads/b/$nr $COMMIT3"
|
|
done
|
|
} | git update-ref --stdin
|
|
'
|
|
|
|
test_expect_success 'sigpipe does not cause pre-push hook failure' '
|
|
echo "exit 0" | write_script "$HOOK" &&
|
|
git push parent1 "refs/heads/b/*:refs/heads/b/*"
|
|
'
|
|
|
|
test_done
|