undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83d0289df6
git-commit-vandalism/t/t5100
History
Jeff King e9d7d10a7f mailinfo: avoid violating strbuf assertion 
In handle_from, we calculate the end boundary of a section
to remove from a strbuf using strcspn like this:

  el = strcspn(buf, set_of_end_boundaries);
  strbuf_remove(&sb, start, el + 1);

This works fine if "el" is the offset of the boundary
character, meaning we remove up to and including that
character. But if the end boundary didn't match (that is, we
hit the end of the string as the boundary instead) then we
want just "el". Asking for "el+1" caught an out-of-bounds
assertion in the strbuf library.

This manifested itself when we got a 'From' header that had
just an email address with nothing else in it (the end of
the string was the end of the address, rather than, e.g., a
trailing '>' character), causing git-mailinfo to barf.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-08-19 19:36:56 -07:00
..
0010 git-mailinfo: Fix getting the subject from the in-body [PATCH] line 2008-07-13 17:21:15 -07:00
info0001 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
info0002 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
info0003 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
info0004 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
info0005 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
info0006 mailinfo: do not get confused with logical lines that are too long. 2007-02-27 01:02:32 -08:00
info0007 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
info0008 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
info0009 mailinfo: feed only one line to handle_filter() for QP input 2008-02-15 22:16:34 -08:00
info0010 git-mailinfo: Fix getting the subject from the in-body [PATCH] line 2008-07-13 17:21:15 -07:00
info0011 mailinfo: fix MIME multi-part message boundary handling 2008-08-09 01:26:35 -07:00
info-from.expect mailinfo: avoid violating strbuf assertion 2008-08-19 19:36:56 -07:00
info-from.in mailinfo: avoid violating strbuf assertion 2008-08-19 19:36:56 -07:00
msg0001 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
msg0002 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
msg0003 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
msg0004 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
msg0005 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
msg0006 mailinfo: do not get confused with logical lines that are too long. 2007-02-27 01:02:32 -08:00
msg0007 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
msg0008 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
msg0009 mailinfo: feed only one line to handle_filter() for QP input 2008-02-15 22:16:34 -08:00
msg0010 git-mailinfo: Fix getting the subject from the in-body [PATCH] line 2008-07-13 17:21:15 -07:00
msg0011 mailinfo: fix MIME multi-part message boundary handling 2008-08-09 01:26:35 -07:00
nul-b64.expect mailinfo: apply the same fix not to lose NULs in BASE64 and QP codepaths 2008-05-25 13:22:18 -07:00
nul-b64.in mailinfo: apply the same fix not to lose NULs in BASE64 and QP codepaths 2008-05-25 13:22:18 -07:00
nul-plain t5100: Avoid filename "nul" 2008-05-27 23:12:29 -07:00
patch0001 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
patch0002 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
patch0003 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
patch0004 t5100: mailinfo and mailsplit tests. 2006-06-17 16:26:20 -07:00
patch0005 git-mailinfo fixes for patch munging 2007-03-31 00:59:19 -07:00
patch0006 mailinfo: do not get confused with logical lines that are too long. 2007-02-27 01:02:32 -08:00
patch0007 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
patch0008 Add a couple more test cases to the suite. 2007-03-12 23:33:41 -07:00
patch0009 mailinfo: feed only one line to handle_filter() for QP input 2008-02-15 22:16:34 -08:00
patch0010 git-mailinfo: Fix getting the subject from the in-body [PATCH] line 2008-07-13 17:21:15 -07:00
patch0011 mailinfo: fix MIME multi-part message boundary handling 2008-08-09 01:26:35 -07:00
sample.mbox mailinfo: re-fix MIME multipart boundary parsing 2008-08-18 22:05:02 -07:00