64472d15e9
When we push using the DAV-based protocol, the client is the one that performs the ref updates and therefore makes the checks to see whether an unforced push should be allowed. We make this check by determining if either (a) we lack the object file for the old value of the ref or (b) the new value of the ref is not newer than the old value, and in either case, reject the push. However, the ref_newer function, which performs this latter check, has an odd behavior due to the reuse of certain object flags. Specifically, it will incorrectly return false in its first invocation and then correctly return true on a subsequent invocation. This occurs because the object flags used by http-push.c are the same as those used by commit-reach.c, which implements ref_newer, and one piece of code misinterprets the flags set by the other. Note that this does not occur in all cases. For example, if the example used in the tests is changed to use one repository instead of two and rewind the head to add a commit, the test passes and we correctly reject the push. However, the example provided does trigger this behavior, and the code has been broken in this way since at least Git 2.0.0. To solve this problem, let's move the two sets of object flags so that they don't overlap, since we're clearly using them at the same time. The new set should not conflict with other usage because other users are either builtin code (which is not compiled into git http-push) or upload-pack (which we similarly do not use here). Reported-by: Michael Ward <mward@smartsoftwareinc.com> Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
194 lines
5.5 KiB
Bash
Executable File
194 lines
5.5 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Clemens Buchacher <drizzd@aon.at>
|
|
#
|
|
|
|
test_description='test WebDAV http-push
|
|
|
|
This test runs various sanity checks on http-push.'
|
|
|
|
. ./test-lib.sh
|
|
|
|
if git http-push > /dev/null 2>&1 || [ $? -eq 128 ]
|
|
then
|
|
skip_all="skipping test, USE_CURL_MULTI is not defined"
|
|
test_done
|
|
fi
|
|
|
|
LIB_HTTPD_DAV=t
|
|
. "$TEST_DIRECTORY"/lib-httpd.sh
|
|
ROOT_PATH="$PWD"
|
|
start_httpd
|
|
|
|
test_expect_success 'setup remote repository' '
|
|
cd "$ROOT_PATH" &&
|
|
mkdir test_repo &&
|
|
cd test_repo &&
|
|
git init &&
|
|
: >path1 &&
|
|
git add path1 &&
|
|
test_tick &&
|
|
git commit -m initial &&
|
|
cd - &&
|
|
git clone --bare test_repo test_repo.git &&
|
|
cd test_repo.git &&
|
|
git --bare update-server-info &&
|
|
mv hooks/post-update.sample hooks/post-update &&
|
|
ORIG_HEAD=$(git rev-parse --verify HEAD) &&
|
|
cd - &&
|
|
mv test_repo.git "$HTTPD_DOCUMENT_ROOT_PATH"
|
|
'
|
|
|
|
test_expect_success 'create password-protected repository' '
|
|
mkdir -p "$HTTPD_DOCUMENT_ROOT_PATH/auth/dumb" &&
|
|
cp -Rf "$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git" \
|
|
"$HTTPD_DOCUMENT_ROOT_PATH/auth/dumb/test_repo.git"
|
|
'
|
|
|
|
setup_askpass_helper
|
|
|
|
test_expect_success 'clone remote repository' '
|
|
cd "$ROOT_PATH" &&
|
|
git clone $HTTPD_URL/dumb/test_repo.git test_repo_clone
|
|
'
|
|
|
|
test_expect_success 'push to remote repository with packed refs' '
|
|
cd "$ROOT_PATH"/test_repo_clone &&
|
|
: >path2 &&
|
|
git add path2 &&
|
|
test_tick &&
|
|
git commit -m path2 &&
|
|
HEAD=$(git rev-parse --verify HEAD) &&
|
|
git push &&
|
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
|
|
test $HEAD = $(git rev-parse --verify HEAD))
|
|
'
|
|
|
|
test_expect_success 'push already up-to-date' '
|
|
git push
|
|
'
|
|
|
|
test_expect_success 'push to remote repository with unpacked refs' '
|
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
|
|
rm packed-refs &&
|
|
git update-ref refs/heads/master $ORIG_HEAD &&
|
|
git --bare update-server-info) &&
|
|
git push &&
|
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
|
|
test $HEAD = $(git rev-parse --verify HEAD))
|
|
'
|
|
|
|
test_expect_success 'http-push fetches unpacked objects' '
|
|
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \
|
|
"$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_unpacked.git &&
|
|
|
|
git clone $HTTPD_URL/dumb/test_repo_unpacked.git \
|
|
"$ROOT_PATH"/fetch_unpacked &&
|
|
|
|
# By reset, we force git to retrieve the object
|
|
(cd "$ROOT_PATH"/fetch_unpacked &&
|
|
git reset --hard HEAD^ &&
|
|
git remote rm origin &&
|
|
git reflog expire --expire=0 --all &&
|
|
git prune &&
|
|
git push -f -v $HTTPD_URL/dumb/test_repo_unpacked.git master)
|
|
'
|
|
|
|
test_expect_success 'http-push fetches packed objects' '
|
|
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \
|
|
"$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_packed.git &&
|
|
|
|
git clone $HTTPD_URL/dumb/test_repo_packed.git \
|
|
"$ROOT_PATH"/test_repo_clone_packed &&
|
|
|
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_packed.git &&
|
|
git --bare repack &&
|
|
git --bare prune-packed) &&
|
|
|
|
# By reset, we force git to retrieve the packed object
|
|
(cd "$ROOT_PATH"/test_repo_clone_packed &&
|
|
git reset --hard HEAD^ &&
|
|
git remote remove origin &&
|
|
git reflog expire --expire=0 --all &&
|
|
git prune &&
|
|
git push -f -v $HTTPD_URL/dumb/test_repo_packed.git master)
|
|
'
|
|
|
|
test_expect_success 'create and delete remote branch' '
|
|
cd "$ROOT_PATH"/test_repo_clone &&
|
|
git checkout -b dev &&
|
|
: >path3 &&
|
|
git add path3 &&
|
|
test_tick &&
|
|
git commit -m dev &&
|
|
git push origin dev &&
|
|
git push origin :dev &&
|
|
test_must_fail git show-ref --verify refs/remotes/origin/dev
|
|
'
|
|
|
|
test_expect_success 'non-force push fails if not up to date' '
|
|
git init --bare "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_conflict.git &&
|
|
git -C "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_conflict.git update-server-info &&
|
|
git clone $HTTPD_URL/dumb/test_repo_conflict.git "$ROOT_PATH"/c1 &&
|
|
git clone $HTTPD_URL/dumb/test_repo_conflict.git "$ROOT_PATH"/c2 &&
|
|
test_commit -C "$ROOT_PATH/c1" path1 &&
|
|
git -C "$ROOT_PATH/c1" push origin HEAD &&
|
|
git -C "$ROOT_PATH/c2" pull &&
|
|
test_commit -C "$ROOT_PATH/c1" path2 &&
|
|
git -C "$ROOT_PATH/c1" push origin HEAD &&
|
|
test_commit -C "$ROOT_PATH/c2" path3 &&
|
|
git -C "$ROOT_PATH/c1" log --graph --all &&
|
|
git -C "$ROOT_PATH/c2" log --graph --all &&
|
|
test_must_fail git -C "$ROOT_PATH/c2" push origin HEAD
|
|
'
|
|
|
|
test_expect_success 'MKCOL sends directory names with trailing slashes' '
|
|
|
|
! grep "\"MKCOL.*[^/] HTTP/[^ ]*\"" < "$HTTPD_ROOT_PATH"/access.log
|
|
|
|
'
|
|
|
|
x1="[0-9a-f]"
|
|
x2="$x1$x1"
|
|
xtrunc=$(echo $OID_REGEX | sed -e "s/\[0-9a-f\]\[0-9a-f\]//")
|
|
|
|
test_expect_success 'PUT and MOVE sends object to URLs with SHA-1 hash suffix' '
|
|
sed \
|
|
-e "s/PUT /OP /" \
|
|
-e "s/MOVE /OP /" \
|
|
-e "s|/objects/$x2/${xtrunc}_$OID_REGEX|WANTED_PATH_REQUEST|" \
|
|
"$HTTPD_ROOT_PATH"/access.log |
|
|
grep -e "\"OP .*WANTED_PATH_REQUEST HTTP/[.0-9]*\" 20[0-9] "
|
|
|
|
'
|
|
|
|
test_http_push_nonff "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \
|
|
"$ROOT_PATH"/test_repo_clone master
|
|
|
|
test_expect_success 'push to password-protected repository (user in URL)' '
|
|
test_commit pw-user &&
|
|
set_askpass user@host pass@host &&
|
|
git push "$HTTPD_URL_USER/auth/dumb/test_repo.git" HEAD &&
|
|
git rev-parse --verify HEAD >expect &&
|
|
git --git-dir="$HTTPD_DOCUMENT_ROOT_PATH/auth/dumb/test_repo.git" \
|
|
rev-parse --verify HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_failure 'user was prompted only once for password' '
|
|
expect_askpass pass user@host
|
|
'
|
|
|
|
test_expect_failure 'push to password-protected repository (no user in URL)' '
|
|
test_commit pw-nouser &&
|
|
set_askpass user@host pass@host &&
|
|
git push "$HTTPD_URL/auth/dumb/test_repo.git" HEAD &&
|
|
expect_askpass both user@host &&
|
|
git rev-parse --verify HEAD >expect &&
|
|
git --git-dir="$HTTPD_DOCUMENT_ROOT_PATH/auth/dumb/test_repo.git" \
|
|
rev-parse --verify HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|