git-commit-vandalism/contrib/emacs
Clifford Caoile dbe48256b4 git.el: Set process-environment instead of invoking env
According to the similar patch from David Kågedal [1], "this will make
it a little less posix-dependent and more efficient." However, there
are two other areas that need to replaced, namely
git-run-command-region and git-run-hooks. This patch implements the
changes of [1] onto those Emacs Lisp functions.

If unpatched, using the git port "msysgit" on Windows will require
defadvice changes as shown at [2] (also explained at 4msysgit.git
[3]).

I have tested git-run-command-region on msysgit, because this is
always called by git-commit (via git-commit-tree <- git-do-commit <-
git-commit-file). However, I could not test git-run-hooks because it
currently does not work on the Emacs Windows port. The latter reports
the hooks files as a+rw and a-x, despite msysgit and cygwin chmod
setting on the respective files.

References:
[1] f27e558643
[2] http://groups.google.com/group/msysgit/browse_thread/thread/b852fef689817707
[3] http://repo.or.cz/w/git/mingw/4msysgit.git?a=commit;h=3c30e5e87358eba7b6d7dcd6301ae8438f0c30ea

Signed-off-by: Clifford Caoile <piyo@users.sourceforge.net>
Acked-by: David Kågedal <davidk@lysator.liu.se>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-04-21 22:56:16 -07:00
..
.gitignore contrib/emacs/Makefile: Provide tool for byte-compiling files. 2006-03-05 11:32:49 -08:00
git-blame.el git-blame.el: show the when, who and what in the minibuffer. 2008-02-11 13:23:15 -08:00
git.el git.el: Set process-environment instead of invoking env 2008-04-21 22:56:16 -07:00
Makefile contrib/emacs/Makefile: Also install .el files. 2007-07-15 20:21:51 -07:00
vc-git.el Add missing functions to contrib/emacs/vc-git.el 2007-07-12 14:38:15 -07:00