03267e8656
The read_cache() in prepare_to_commit() would end up clobbering the pointer we had for a previously populated "the_index.cache_tree" in the very common case of "git commit" stressed by e.g. the tests being changed here. We'd populate "the_index.cache_tree" by calling "update_main_cache_tree" in prepare_index(), but would not end up with a "fully prepared" index. What constitutes an existing index is clearly overly fuzzy, here we'll check "active_nr" (aka "the_index.cache_nr"), but our "the_index.cache_tree" might have been malloc()'d already. Thus the code added in11c8a74a64(commit: write cache-tree data when writing index anyway, 2011-12-06) would end up allocating the "cache_tree", and would interact here with code added in7168624c35(Do not generate full commit log message if it is not going to be used, 2007-11-28). The result was a very common memory leak. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>
40 lines
1.0 KiB
Bash
Executable File
40 lines
1.0 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='ignored hook warning'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
test_hook --setup pre-commit <<-\EOF
|
|
exit 0
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'no warning if hook is not ignored' '
|
|
git commit --allow-empty -m "more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'warning if hook is ignored' '
|
|
test_hook --disable pre-commit &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'no warning if advice.ignoredHook set to false' '
|
|
test_config advice.ignoredHook false &&
|
|
test_hook --disable pre-commit &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success 'no warning if unset advice.ignoredHook and hook removed' '
|
|
test_hook --remove pre-commit &&
|
|
test_unconfig advice.ignoredHook &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_done
|