a8cbc89589
Currently, the git diff hunk headers show the wrong method signature if the method has a qualified return type, an array return type, or a generic return type because the regex doesn't allow dots (.), [], or < and > in the return type. Also, type parameter declarations couldn't be matched. Add several t4018 tests asserting the right hunk headers for different cases: - enum constant change - change in generic method with bounded type parameters - change in generic method with wildcard - field change in a nested class Signed-off-by: Tassilo Horn <tsdh@gnu.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> |
||
---|---|---|
.. | ||
bash-arithmetic-function | ||
bash-bashism-style-compact | ||
bash-bashism-style-function | ||
bash-bashism-style-whitespace | ||
bash-conditional-function | ||
bash-missing-parentheses | ||
bash-mixed-style-compact | ||
bash-mixed-style-function | ||
bash-nested-functions | ||
bash-other-characters | ||
bash-posix-style-compact | ||
bash-posix-style-function | ||
bash-posix-style-whitespace | ||
bash-subshell-function | ||
bash-trailing-comment | ||
cpp-c++-function | ||
cpp-class-constructor | ||
cpp-class-constructor-mem-init | ||
cpp-class-definition | ||
cpp-class-definition-derived | ||
cpp-class-destructor | ||
cpp-function-returning-global-type | ||
cpp-function-returning-nested | ||
cpp-function-returning-pointer | ||
cpp-function-returning-reference | ||
cpp-gnu-style-function | ||
cpp-namespace-definition | ||
cpp-operator-definition | ||
cpp-skip-access-specifiers | ||
cpp-skip-comment-block | ||
cpp-skip-labels | ||
cpp-struct-definition | ||
cpp-struct-single-line | ||
cpp-template-function-definition | ||
cpp-union-definition | ||
cpp-void-c-function | ||
css-attribute-value-selector | ||
css-block-level-@-statements | ||
css-brace-in-col-1 | ||
css-class-selector | ||
css-colon-eol | ||
css-colon-selector | ||
css-common | ||
css-id-selector | ||
css-long-selector-list | ||
css-prop-sans-indent | ||
css-root-selector | ||
css-short-selector-list | ||
css-trailing-space | ||
custom1-pattern | ||
custom2-match-to-end-of-line | ||
custom3-alternation-in-pattern | ||
dts-labels | ||
dts-node-unitless | ||
dts-nodes | ||
dts-nodes-boolean-prop | ||
dts-nodes-comment1 | ||
dts-nodes-comment2 | ||
dts-nodes-multiline-prop | ||
dts-reference | ||
dts-root | ||
dts-root-comment | ||
elixir-do-not-pick-end | ||
elixir-ex-unit-test | ||
elixir-function | ||
elixir-macro | ||
elixir-module | ||
elixir-module-func | ||
elixir-nested-module | ||
elixir-private-function | ||
elixir-protocol | ||
elixir-protocol-implementation | ||
fortran-block-data | ||
fortran-comment | ||
fortran-comment-keyword | ||
fortran-comment-legacy | ||
fortran-comment-legacy-star | ||
fortran-external-function | ||
fortran-external-subroutine | ||
fortran-module | ||
fortran-module-procedure | ||
fortran-program | ||
fountain-scene | ||
golang-complex-function | ||
golang-func | ||
golang-interface | ||
golang-long-func | ||
golang-struct | ||
java-class-member-function | ||
java-enum-constant | ||
java-method-return-generic-bounded | ||
java-method-return-generic-wildcard | ||
java-nested-field | ||
markdown-heading-indented | ||
markdown-heading-non-headings | ||
matlab-class-definition | ||
matlab-function | ||
matlab-octave-section-1 | ||
matlab-octave-section-2 | ||
matlab-section | ||
perl-skip-end-of-heredoc | ||
perl-skip-forward-decl | ||
perl-skip-sub-in-pod | ||
perl-sub-definition | ||
perl-sub-definition-kr-brace | ||
php-abstract-class | ||
php-abstract-method | ||
php-class | ||
php-final-class | ||
php-final-method | ||
php-function | ||
php-interface | ||
php-method | ||
php-trait | ||
python-async-def | ||
python-class | ||
python-def | ||
python-indented-async-def | ||
python-indented-class | ||
python-indented-def | ||
README | ||
rust-fn | ||
rust-impl | ||
rust-macro-rules | ||
rust-struct | ||
rust-trait | ||
scheme-class | ||
scheme-def | ||
scheme-def-variant | ||
scheme-define-slash-public | ||
scheme-define-syntax | ||
scheme-define-variant | ||
scheme-library | ||
scheme-local-define | ||
scheme-module | ||
scheme-top-level-define | ||
scheme-user-defined-define |
How to write RIGHT test cases ============================= Insert the word "ChangeMe" (exactly this form) at a distance of at least two lines from the line that must appear in the hunk header. The text that must appear in the hunk header must contain the word "right", but in all upper-case, like in the title above. This text is a bit twisted and out of order, but it is itself a test case for the default hunk header pattern. Know what you are doing if you change it. BTW, this tests that the head line goes to the hunk header, not the line of equal signs.