ad43e37839
Avoid creating unnecessary trailing whitespace in normal target format error messages when the message is omitted. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
323 lines
8.2 KiB
C
323 lines
8.2 KiB
C
#include "cache.h"
|
|
#include "config.h"
|
|
#include "run-command.h"
|
|
#include "quote.h"
|
|
#include "version.h"
|
|
#include "trace2/tr2_dst.h"
|
|
#include "trace2/tr2_sysenv.h"
|
|
#include "trace2/tr2_tbuf.h"
|
|
#include "trace2/tr2_tgt.h"
|
|
#include "trace2/tr2_tls.h"
|
|
|
|
static struct tr2_dst tr2dst_normal = { TR2_SYSENV_NORMAL, 0, 0, 0 };
|
|
|
|
/*
|
|
* Use the TR2_SYSENV_NORMAL_BRIEF setting to omit the "<time> <file>:<line>"
|
|
* fields from each line written to the builtin normal target.
|
|
*
|
|
* Unit tests may want to use this to help with testing.
|
|
*/
|
|
static int tr2env_normal_be_brief;
|
|
|
|
#define TR2FMT_NORMAL_FL_WIDTH (50)
|
|
|
|
static int fn_init(void)
|
|
{
|
|
int want = tr2_dst_trace_want(&tr2dst_normal);
|
|
int want_brief;
|
|
const char *brief;
|
|
|
|
if (!want)
|
|
return want;
|
|
|
|
brief = tr2_sysenv_get(TR2_SYSENV_NORMAL_BRIEF);
|
|
if (brief && *brief &&
|
|
((want_brief = git_parse_maybe_bool(brief)) != -1))
|
|
tr2env_normal_be_brief = want_brief;
|
|
|
|
return want;
|
|
}
|
|
|
|
static void fn_term(void)
|
|
{
|
|
tr2_dst_trace_disable(&tr2dst_normal);
|
|
}
|
|
|
|
static void normal_fmt_prepare(const char *file, int line, struct strbuf *buf)
|
|
{
|
|
strbuf_setlen(buf, 0);
|
|
|
|
if (!tr2env_normal_be_brief) {
|
|
struct tr2_tbuf tb_now;
|
|
|
|
tr2_tbuf_local_time(&tb_now);
|
|
strbuf_addstr(buf, tb_now.buf);
|
|
strbuf_addch(buf, ' ');
|
|
|
|
if (file && *file)
|
|
strbuf_addf(buf, "%s:%d ", file, line);
|
|
while (buf->len < TR2FMT_NORMAL_FL_WIDTH)
|
|
strbuf_addch(buf, ' ');
|
|
}
|
|
}
|
|
|
|
static void normal_io_write_fl(const char *file, int line,
|
|
const struct strbuf *buf_payload)
|
|
{
|
|
struct strbuf buf_line = STRBUF_INIT;
|
|
|
|
normal_fmt_prepare(file, line, &buf_line);
|
|
strbuf_addbuf(&buf_line, buf_payload);
|
|
tr2_dst_write_line(&tr2dst_normal, &buf_line);
|
|
strbuf_release(&buf_line);
|
|
}
|
|
|
|
static void fn_version_fl(const char *file, int line)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "version %s", git_version_string);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_start_fl(const char *file, int line,
|
|
uint64_t us_elapsed_absolute, const char **argv)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addstr(&buf_payload, "start ");
|
|
sq_quote_argv_pretty(&buf_payload, argv);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_exit_fl(const char *file, int line, uint64_t us_elapsed_absolute,
|
|
int code)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
double elapsed = (double)us_elapsed_absolute / 1000000.0;
|
|
|
|
strbuf_addf(&buf_payload, "exit elapsed:%.6f code:%d", elapsed, code);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_signal(uint64_t us_elapsed_absolute, int signo)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
double elapsed = (double)us_elapsed_absolute / 1000000.0;
|
|
|
|
strbuf_addf(&buf_payload, "signal elapsed:%.6f code:%d", elapsed,
|
|
signo);
|
|
normal_io_write_fl(__FILE__, __LINE__, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_atexit(uint64_t us_elapsed_absolute, int code)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
double elapsed = (double)us_elapsed_absolute / 1000000.0;
|
|
|
|
strbuf_addf(&buf_payload, "atexit elapsed:%.6f code:%d", elapsed, code);
|
|
normal_io_write_fl(__FILE__, __LINE__, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void maybe_append_string_va(struct strbuf *buf, const char *fmt,
|
|
va_list ap)
|
|
{
|
|
if (fmt && *fmt) {
|
|
va_list copy_ap;
|
|
|
|
va_copy(copy_ap, ap);
|
|
strbuf_vaddf(buf, fmt, copy_ap);
|
|
va_end(copy_ap);
|
|
return;
|
|
}
|
|
}
|
|
|
|
static void fn_error_va_fl(const char *file, int line, const char *fmt,
|
|
va_list ap)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addstr(&buf_payload, "error");
|
|
if (fmt && *fmt) {
|
|
strbuf_addch(&buf_payload, ' ');
|
|
maybe_append_string_va(&buf_payload, fmt, ap);
|
|
}
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_command_path_fl(const char *file, int line, const char *pathname)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "cmd_path %s", pathname);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_command_name_fl(const char *file, int line, const char *name,
|
|
const char *hierarchy)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "cmd_name %s", name);
|
|
if (hierarchy && *hierarchy)
|
|
strbuf_addf(&buf_payload, " (%s)", hierarchy);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_command_mode_fl(const char *file, int line, const char *mode)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "cmd_mode %s", mode);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_alias_fl(const char *file, int line, const char *alias,
|
|
const char **argv)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "alias %s ->", alias);
|
|
sq_quote_argv_pretty(&buf_payload, argv);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_child_start_fl(const char *file, int line,
|
|
uint64_t us_elapsed_absolute,
|
|
const struct child_process *cmd)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "child_start[%d] ", cmd->trace2_child_id);
|
|
|
|
if (cmd->dir) {
|
|
strbuf_addstr(&buf_payload, " cd");
|
|
sq_quote_buf_pretty(&buf_payload, cmd->dir);
|
|
strbuf_addstr(&buf_payload, "; ");
|
|
}
|
|
|
|
/*
|
|
* TODO if (cmd->env) { Consider dumping changes to environment. }
|
|
* See trace_add_env() in run-command.c as used by original trace.c
|
|
*/
|
|
|
|
if (cmd->git_cmd)
|
|
strbuf_addstr(&buf_payload, "git");
|
|
sq_quote_argv_pretty(&buf_payload, cmd->argv);
|
|
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_child_exit_fl(const char *file, int line,
|
|
uint64_t us_elapsed_absolute, int cid, int pid,
|
|
int code, uint64_t us_elapsed_child)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
double elapsed = (double)us_elapsed_child / 1000000.0;
|
|
|
|
strbuf_addf(&buf_payload, "child_exit[%d] pid:%d code:%d elapsed:%.6f",
|
|
cid, pid, code, elapsed);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_exec_fl(const char *file, int line, uint64_t us_elapsed_absolute,
|
|
int exec_id, const char *exe, const char **argv)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "exec[%d] ", exec_id);
|
|
if (exe)
|
|
strbuf_addstr(&buf_payload, exe);
|
|
sq_quote_argv_pretty(&buf_payload, argv);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_exec_result_fl(const char *file, int line,
|
|
uint64_t us_elapsed_absolute, int exec_id,
|
|
int code)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "exec_result[%d] code:%d", exec_id, code);
|
|
if (code > 0)
|
|
strbuf_addf(&buf_payload, " err:%s", strerror(code));
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_param_fl(const char *file, int line, const char *param,
|
|
const char *value)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf_payload, "def_param %s=%s", param, value);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_repo_fl(const char *file, int line,
|
|
const struct repository *repo)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
strbuf_addstr(&buf_payload, "worktree ");
|
|
sq_quote_buf_pretty(&buf_payload, repo->worktree);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
static void fn_printf_va_fl(const char *file, int line,
|
|
uint64_t us_elapsed_absolute, const char *fmt,
|
|
va_list ap)
|
|
{
|
|
struct strbuf buf_payload = STRBUF_INIT;
|
|
|
|
maybe_append_string_va(&buf_payload, fmt, ap);
|
|
normal_io_write_fl(file, line, &buf_payload);
|
|
strbuf_release(&buf_payload);
|
|
}
|
|
|
|
struct tr2_tgt tr2_tgt_normal = {
|
|
&tr2dst_normal,
|
|
|
|
fn_init,
|
|
fn_term,
|
|
|
|
fn_version_fl,
|
|
fn_start_fl,
|
|
fn_exit_fl,
|
|
fn_signal,
|
|
fn_atexit,
|
|
fn_error_va_fl,
|
|
fn_command_path_fl,
|
|
fn_command_name_fl,
|
|
fn_command_mode_fl,
|
|
fn_alias_fl,
|
|
fn_child_start_fl,
|
|
fn_child_exit_fl,
|
|
NULL, /* thread_start */
|
|
NULL, /* thread_exit */
|
|
fn_exec_fl,
|
|
fn_exec_result_fl,
|
|
fn_param_fl,
|
|
fn_repo_fl,
|
|
NULL, /* region_enter */
|
|
NULL, /* region_leave */
|
|
NULL, /* data */
|
|
NULL, /* data_json */
|
|
fn_printf_va_fl,
|
|
};
|