git-commit-vandalism/contrib/completion
Felipe Contreras b4cfbc969c completion: inline __gitcomp_1 to its sole callsite
There is no point in calling a separate function that is only used
in one place. Especially considering that there's no need to call
compgen, and we traverse the words ourselves both in __gitcompadd,
and __gitcomp_1.

Let's squash the functions together, and traverse only once.

This improves performance. For N number of words:

  == 1 ==
  original: 0.002s
  new: 0.000s
  == 10 ==
  original: 0.005s
  new: 0.001s
  == 100 ==
  original: 0.009s
  new: 0.006s
  == 1000 ==
  original: 0.027s
  new: 0.019s
  == 10000 ==
  original: 0.163s
  new: 0.151s
  == 100000 ==
  original: 1.555s
  new: 1.497s

No functional changes.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-04-14 23:18:58 -07:00
..
git-completion.bash completion: inline __gitcomp_1 to its sole callsite 2013-04-14 23:18:58 -07:00
git-completion.tcsh Merge branch 'mk/tcsh-complete-only-known-paths' 2013-02-08 15:28:51 -08:00
git-completion.zsh git-completion.zsh: define __gitcomp_file compatibility function 2013-03-05 08:54:03 -08:00
git-prompt.sh bash: teach __git_ps1 about REVERT_HEAD 2013-03-31 19:07:26 -07:00