b6046abc0c
Fix various leaks in built-ins, libraries and a test helper here we were missing a call to strbuf_release(), string_list_clear() etc, or were calling them after a potential "return". Comments on individual changes: - builtin/checkout.c: Fix a memory leak that was introduced in [1]. A sibling leak introduced in [2] was recently fixed in [3]. As with [3] we should be using the wt_status_state_free_buffers() API introduced in [4]. - builtin/repack.c: Fix a leak that's been here since this use of "strbuf_release()" was added ina1bbc6c017(repack: rewrite the shell script in C, 2013-09-15). We don't use the variable for anything except this loop, so we can instead free it right afterwards. - builtin/rev-parse: Fix a leak that's been here since this code was added in21d4783538(Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts., 2007-11-04). - builtin/stash.c: Fix a couple of leaks that have been here since this code was added ind4788af875(stash: convert create to builtin, 2019-02-25), we strbuf_release()'d only some of the "struct strbuf" we allocated earlier in the function, let's release all of them. - ref-filter.c: Fix a leak in482c119186(gpg-interface: improve interface for parsing tags, 2021-02-11), we don't use the "payload" variable that we ask parse_signature() to populate for us, so let's free it. - t/helper/test-fake-ssh.c: Fix a leak that's been here since this code was added in3064d5a38c(mingw: fix t5601-clone.sh, 2016-01-27). Let's free the "struct strbuf" as soon as we don't need it anymore. 1.c45f0f525d(switch: reject if some operation is in progress, 2019-03-29) 2.2708ce62d2(branch: sort detached HEAD based on a flag, 2021-01-07) 3.abcac2e19f(ref-filter.c: fix a leak in get_head_description, 2022-09-25) 4.962dd7ebc3(wt-status: introduce wt_status_state_free_buffers(), 2020-09-27). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>
32 lines
838 B
C
32 lines
838 B
C
#include "git-compat-util.h"
|
|
#include "run-command.h"
|
|
#include "strbuf.h"
|
|
|
|
int cmd_main(int argc, const char **argv)
|
|
{
|
|
const char *trash_directory = getenv("TRASH_DIRECTORY");
|
|
struct strbuf buf = STRBUF_INIT;
|
|
FILE *f;
|
|
int i;
|
|
const char *child_argv[] = { NULL, NULL };
|
|
|
|
/* First, print all parameters into $TRASH_DIRECTORY/ssh-output */
|
|
if (!trash_directory)
|
|
die("Need a TRASH_DIRECTORY!");
|
|
strbuf_addf(&buf, "%s/ssh-output", trash_directory);
|
|
f = fopen(buf.buf, "w");
|
|
if (!f)
|
|
die("Could not write to %s", buf.buf);
|
|
strbuf_release(&buf);
|
|
for (i = 0; i < argc; i++)
|
|
fprintf(f, "%s%s", i > 0 ? " " : "", i > 0 ? argv[i] : "ssh:");
|
|
fprintf(f, "\n");
|
|
fclose(f);
|
|
|
|
/* Now, evaluate the *last* parameter */
|
|
if (argc < 2)
|
|
return 0;
|
|
child_argv[0] = argv[argc - 1];
|
|
return run_command_v_opt(child_argv, RUN_USING_SHELL);
|
|
}
|