Jeff King b83a3089b5 server-info: fix blind pointer arithmetic
When we're writing out a new objects/info/packs file, we read back the
old one to try to keep the ordering the same. When we see a line
starting with "P", we expect "P pack-1234..." and blindly jump to "line
+ 2" to parse the pack name. If we saw a line with _just_ "P" and
nothing else, we'd jump past the end of the buffer and start reading
arbitrary memory.

This shouldn't be a big attack vector, as the files are local to the
repository and written by us, but it's clearly worth fixing (we do read
remote copies of the file for dumb-http fetches, but using a totally
different parser!).

Let's instead use skip_prefix() here, which avoids pointer arithmetic
altogether. Note that this converts our switch statement to an if/else
chain, making it slightly more verbose. But it will also make it easier
to do a few follow-on cleanups.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-04-16 16:58:21 +09:00
2019-03-02 19:12:58 +01:00
2018-08-02 13:54:58 -07:00
2019-04-16 16:58:21 +09:00
2018-08-20 12:41:32 -07:00
2018-12-09 12:37:32 +09:00
2019-01-14 15:29:32 -08:00
2019-02-06 22:05:23 -08:00
2018-09-12 15:15:34 -07:00
2019-01-02 10:19:05 -08:00
2019-01-14 12:13:04 -08:00
2018-11-02 11:04:53 +09:00
2019-02-05 14:26:09 -08:00
2019-02-05 14:26:09 -08:00
2018-11-19 16:24:41 +09:00
2018-08-20 12:41:32 -07:00
2019-02-06 22:05:24 -08:00
2019-02-05 14:26:17 -08:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2019-02-06 22:05:23 -08:00
2019-01-14 15:29:29 -08:00
2019-02-24 07:55:19 -08:00
2019-02-06 22:05:23 -08:00
2018-11-05 13:42:11 +09:00
2018-12-12 17:18:29 +09:00
2018-08-29 13:05:35 -07:00
2019-01-14 12:13:04 -08:00
2019-02-07 13:02:28 -08:00
2018-10-04 11:12:14 -07:00
2018-10-04 11:12:14 -07:00
2019-01-04 13:33:31 -08:00
2018-10-19 13:34:02 +09:00
2019-01-04 13:33:32 -08:00
2019-02-06 22:05:23 -08:00
2019-02-05 14:26:09 -08:00
2019-02-05 14:26:09 -08:00
2018-11-02 12:14:21 +09:00
2018-11-02 12:14:21 +09:00
2018-12-09 12:37:32 +09:00
2018-08-15 15:08:23 -07:00
2018-09-17 13:53:52 -07:00
2019-02-06 22:05:23 -08:00
2019-02-06 22:05:23 -08:00
2019-01-14 12:13:04 -08:00
2019-02-05 14:26:11 -08:00
2018-11-02 11:04:54 +09:00
2018-11-02 11:04:54 +09:00
2019-02-06 22:05:23 -08:00
2018-12-09 12:37:32 +09:00
2019-01-29 12:47:56 -08:00
2019-02-06 22:05:23 -08:00
2018-08-15 11:52:09 -07:00
2018-10-19 13:34:02 +09:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
Git with broken hash generation to generate collisions between object IDs. Don't use this!
https://undefinedbehavior.de/posts/commit-vandalism/
Readme 217 MiB
Languages
C 50%
Shell 38.2%
Perl 5.5%
Tcl 3.5%
Python 0.9%
Other 1.7%