e52290428b
Corrected the log starting time displayed in the error message (as it was always showing the epoch due to a bad input to strtoul). Improved the log parser so we only scan backwards towards the '\n' from the end of the prior log; during this scan the last '>' is remembered to improve performance (rather than scanning forward to it). If the log record matched is the last log record in the file only use its new sha1 value if the date matches exactly; otherwise we leave the passed in sha1 alone as it already contains the current value of the ref. This way lookups of dates later than the log end to stick with the current ref value in case the ref was updated without logging. If it looks like someone changed the ref without logging it and we are going to return the sha1 which should have been valid during the missing period then warn the user that there might be log data missing and thus their query result may not be accurate. The check isn't perfect as its just based on comparing the old and new sha1 values between the two log records but its better than not checking at all. Implemented test cases based on git-rev-parse for most of the boundary conditions. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net> |
||
---|---|---|
.. | ||
t4100 | ||
.gitignore | ||
annotate-tests.sh | ||
diff-lib.sh | ||
lib-read-tree-m-3way.sh | ||
Makefile | ||
README | ||
t0000-basic.sh | ||
t0010-racy-git.sh | ||
t1000-read-tree-m-3way.sh | ||
t1001-read-tree-m-2way.sh | ||
t1002-read-tree-m-u-2way.sh | ||
t1100-commit-tree-options.sh | ||
t1200-tutorial.sh | ||
t1300-repo-config.sh | ||
t1400-update-ref.sh | ||
t2000-checkout-cache-clash.sh | ||
t2001-checkout-cache-clash.sh | ||
t2002-checkout-cache-u.sh | ||
t2003-checkout-cache-mkdir.sh | ||
t2004-checkout-cache-temp.sh | ||
t2100-update-cache-badpath.sh | ||
t2101-update-index-reupdate.sh | ||
t3000-ls-files-others.sh | ||
t3001-ls-files-others-exclude.sh | ||
t3002-ls-files-dashpath.sh | ||
t3010-ls-files-killed-modified.sh | ||
t3020-ls-files-error-unmatch.sh | ||
t3100-ls-tree-restrict.sh | ||
t3101-ls-tree-dirname.sh | ||
t3200-branch.sh | ||
t3300-funny-names.sh | ||
t3400-rebase.sh | ||
t3401-rebase-partial.sh | ||
t3500-cherry.sh | ||
t3600-rm.sh | ||
t3700-add.sh | ||
t4000-diff-format.sh | ||
t4001-diff-rename.sh | ||
t4002-diff-basic.sh | ||
t4003-diff-rename-1.sh | ||
t4004-diff-rename-symlink.sh | ||
t4005-diff-rename-2.sh | ||
t4006-diff-mode.sh | ||
t4007-rename-3.sh | ||
t4008-diff-break-rewrite.sh | ||
t4009-diff-rename-4.sh | ||
t4010-diff-pathspec.sh | ||
t4011-diff-symlink.sh | ||
t4012-diff-binary.sh | ||
t4100-apply-stat.sh | ||
t4101-apply-nonl.sh | ||
t4102-apply-rename.sh | ||
t4103-apply-binary.sh | ||
t4109-apply-multifrag.sh | ||
t4110-apply-scan.sh | ||
t4112-apply-renames.sh | ||
t5000-tar-tree.sh | ||
t5300-pack-object.sh | ||
t5400-send-pack.sh | ||
t5500-fetch-pack.sh | ||
t5600-clone-fail-cleanup.sh | ||
t5700-clone-reference.sh | ||
t5710-info-alternate.sh | ||
t6000lib.sh | ||
t6002-rev-list-bisect.sh | ||
t6003-rev-list-topo-order.sh | ||
t6010-merge-base.sh | ||
t6020-merge-df.sh | ||
t6021-merge-criss-cross.sh | ||
t6022-merge-rename.sh | ||
t6101-rev-parse-parents.sh | ||
t7001-mv.sh | ||
t7101-reset.sh | ||
t8001-annotate.sh | ||
t8002-blame.sh | ||
test4012.png | ||
test-lib.sh |
Core GIT Tests ============== This directory holds many test scripts for core GIT tools. The first part of this short document describes how to run the tests and read their output. When fixing the tools or adding enhancements, you are strongly encouraged to add tests in this directory to cover what you are trying to fix or enhance. The later part of this short document describes how your test scripts should be organized. Running Tests ------------- The easiest way to run tests is to say "make". This runs all the tests. *** t0000-basic.sh *** * ok 1: .git/objects should be empty after git-init-db in an empty repo. * ok 2: .git/objects should have 256 subdirectories. * ok 3: git-update-index without --add should fail adding. ... * ok 23: no diff after checkout and git-update-index --refresh. * passed all 23 test(s) *** t0100-environment-names.sh *** * ok 1: using old names should issue warnings. * ok 2: using old names but having new names should not issue warnings. ... Or you can run each test individually from command line, like this: $ sh ./t3001-ls-files-killed.sh * ok 1: git-update-index --add to add various paths. * ok 2: git-ls-files -k to show killed files. * ok 3: validate git-ls-files -k output. * passed all 3 test(s) You can pass --verbose (or -v), --debug (or -d), and --immediate (or -i) command line argument to the test. --verbose:: This makes the test more verbose. Specifically, the command being run and their output if any are also output. --debug:: This may help the person who is developing a new test. It causes the command defined with test_debug to run. --immediate:: This causes the test to immediately exit upon the first failed test. Naming Tests ------------ The test files are named as: tNNNN-commandname-details.sh where N is a decimal digit. First digit tells the family: 0 - the absolute basics and global stuff 1 - the basic commands concerning database 2 - the basic commands concerning the working tree 3 - the other basic commands (e.g. ls-files) 4 - the diff commands 5 - the pull and exporting commands 6 - the revision tree commands (even e.g. merge-base) Second digit tells the particular command we are testing. Third digit (optionally) tells the particular switch or group of switches we are testing. If you create files under t/ directory (i.e. here) that is not the top-level test script, never name the file to match the above pattern. The Makefile here considers all such files as the top-level test script and tries to run all of them. A care is especially needed if you are creating a common test library file, similar to test-lib.sh, because such a library file may not be suitable for standalone execution. Writing Tests ------------- The test script is written as a shell script. It should start with the standard "#!/bin/sh" with copyright notices, and an assignment to variable 'test_description', like this: #!/bin/sh # # Copyright (c) 2005 Junio C Hamano # test_description='xxx test (option --frotz) This test registers the following structure in the cache and tries to run git-ls-files with option --frotz.' Source 'test-lib.sh' -------------------- After assigning test_description, the test script should source test-lib.sh like this: . ./test-lib.sh This test harness library does the following things: - If the script is invoked with command line argument --help (or -h), it shows the test_description and exits. - Creates an empty test directory with an empty .git/objects database and chdir(2) into it. This directory is 't/trash' if you must know, but I do not think you care. - Defines standard test helper functions for your scripts to use. These functions are designed to make all scripts behave consistently when command line arguments --verbose (or -v), --debug (or -d), and --immediate (or -i) is given. End with test_done ------------------ Your script will be a sequence of tests, using helper functions from the test harness library. At the end of the script, call 'test_done'. Test harness library -------------------- There are a handful helper functions defined in the test harness library for your script to use. - test_expect_success <message> <script> This takes two strings as parameter, and evaluates the <script>. If it yields success, test is considered successful. <message> should state what it is testing. Example: test_expect_success \ 'git-write-tree should be able to write an empty tree.' \ 'tree=$(git-write-tree)' - test_expect_failure <message> <script> This is the opposite of test_expect_success. If <script> yields success, test is considered a failure. Example: test_expect_failure \ 'git-update-index without --add should fail adding.' \ 'git-update-index should-be-empty' - test_debug <script> This takes a single argument, <script>, and evaluates it only when the test script is started with --debug command line argument. This is primarily meant for use during the development of a new test script. - test_done Your test script must have test_done at the end. Its purpose is to summarize successes and failures in the test script and exit with an appropriate error code. Tips for Writing Tests ---------------------- As with any programming projects, existing programs are the best source of the information. However, do _not_ emulate t0000-basic.sh when writing your tests. The test is special in that it tries to validate the very core of GIT. For example, it knows that there will be 256 subdirectories under .git/objects/, and it knows that the object ID of an empty tree is a certain 40-byte string. This is deliberately done so in t0000-basic.sh because the things the very basic core test tries to achieve is to serve as a basis for people who are changing the GIT internal drastically. For these people, after making certain changes, not seeing failures from the basic test _is_ a failure. And such drastic changes to the core GIT that even changes these otherwise supposedly stable object IDs should be accompanied by an update to t0000-basic.sh. However, other tests that simply rely on basic parts of the core GIT working properly should not have that level of intimate knowledge of the core GIT internals. If all the test scripts hardcoded the object IDs like t0000-basic.sh does, that defeats the purpose of t0000-basic.sh, which is to isolate that level of validation in one place. Your test also ends up needing updating when such a change to the internal happens, so do _not_ do it and leave the low level of validation to t0000-basic.sh.