5778b22b3d
Since its introduction in 7249e91 (revision.c: support --notes
command-line option, 2011-03-29), combining '--notes' with any option
that causes us to format notes (e.g., '--pretty', '--format="%N"', etc)
results in a failed assertion at runtime.
$ git rev-list HEAD | git diff-tree --stdin --pretty=medium --notes
commit 8f3d9f354286745c751374f5f1fcafee6b3f3136
git: notes.c:1308: format_display_notes: Assertion `display_notes_trees' failed.
Aborted
This failure is due to diff-tree not calling 'load_display_notes' to
initialize the notes machinery.
Ordinarily, this failure isn't triggered, because it requires passing
both '--notes' and another of the above mentioned options. In the case
of '--pretty', for example, we set 'opt->verbose_header', causing
'show_log()' to eventually call 'format_display_notes()', which expects
a non-NULL 'display_note_trees'.
Without initializing the notes machinery, 'display_note_trees' remains
NULL, and thus triggers an assertion failure.
Fix this by initializing the notes machinery after parsing our options,
and harden this behavior against regression with a test in t4013. (Note
that the added ref in this test requires updating two unrelated tests
which use 'log --all', and thus need to learn about the new refs).
Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
62 lines
1.5 KiB
Plaintext
62 lines
1.5 KiB
Plaintext
$ git log --decorate --all
|
|
commit b7e0bc69303b488b47deca799a7d723971dfa6cd (mode)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:06:00 2006 +0000
|
|
|
|
update mode
|
|
|
|
commit a6f364368ca320bc5a92e18912e16fa6b3dff598 (note)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:06:00 2006 +0000
|
|
|
|
update mode (file2)
|
|
|
|
Notes:
|
|
note
|
|
|
|
commit cd4e72fd96faed3f0ba949dc42967430374e2290 (rearrange)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:06:00 2006 +0000
|
|
|
|
Rearranged lines in dir/sub
|
|
|
|
commit cbacedd14cb8b89255a2c02b59e77a2e9a8021a0 (refs/notes/commits)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:06:00 2006 +0000
|
|
|
|
Notes added by 'git notes add'
|
|
|
|
commit 59d314ad6f356dd08601a4cd5e530381da3e3c64 (HEAD -> master)
|
|
Merge: 9a6d494 c7a2ab9
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:04:00 2006 +0000
|
|
|
|
Merge branch 'side'
|
|
|
|
commit c7a2ab9e8eac7b117442a607d5a9b3950ae34d5a (side)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:03:00 2006 +0000
|
|
|
|
Side
|
|
|
|
commit 9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:02:00 2006 +0000
|
|
|
|
Third
|
|
|
|
commit 1bde4ae5f36c8d9abe3a0fce0c6aab3c4a12fe44
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:01:00 2006 +0000
|
|
|
|
Second
|
|
|
|
This is the second commit.
|
|
|
|
commit 444ac553ac7612cc88969031b02b3767fb8a353a (initial)
|
|
Author: A U Thor <author@example.com>
|
|
Date: Mon Jun 26 00:00:00 2006 +0000
|
|
|
|
Initial
|
|
$
|