cddd68ae33
Since [1] running "make coccicheck" has resulted in [2] being emitted
to the *.log files for the "spatch" run, and in the case of "make
coccicheck-test" we'd emit these to the user's terminal.
Nothing was broken as a result, but let's refactor the relevant rules
to eliminate the ambiguity between a possible variable and an
identifier.
1. 0e6550a2c6 (cocci: add a index-compatibility.pending.cocci,
2022-11-19)
2. warning: line 257: should active_cache be a metavariable?
warning: line 260: should active_cache_changed be a metavariable?
warning: line 263: should active_cache_tree be a metavariable?
warning: line 271: should active_nr be a metavariable?
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
140 lines
1.6 KiB
Plaintext
140 lines
1.6 KiB
Plaintext
// the_index.* variables
|
|
@@
|
|
identifier AC = active_cache;
|
|
identifier ACC = active_cache_changed;
|
|
identifier ACT = active_cache_tree;
|
|
@@
|
|
(
|
|
- AC
|
|
+ the_index.cache
|
|
|
|
|
- ACC
|
|
+ the_index.cache_changed
|
|
|
|
|
- ACT
|
|
+ the_index.cache_tree
|
|
)
|
|
|
|
@@
|
|
identifier AN = active_nr;
|
|
identifier f != prepare_to_commit;
|
|
@@
|
|
f(...) {<...
|
|
- AN
|
|
+ the_index.cache_nr
|
|
...>}
|
|
|
|
// "the_repository" simple cases
|
|
@@
|
|
@@
|
|
(
|
|
- read_cache_unmerged
|
|
+ repo_read_index_unmerged
|
|
|
|
|
- hold_locked_index
|
|
+ repo_hold_locked_index
|
|
)
|
|
(
|
|
+ the_repository,
|
|
...)
|
|
|
|
// "the_repository" special-cases
|
|
@@
|
|
@@
|
|
(
|
|
- read_cache_preload
|
|
+ repo_read_index_preload
|
|
)
|
|
(
|
|
+ the_repository,
|
|
...
|
|
+ , 0
|
|
)
|
|
|
|
// "the_index" simple cases
|
|
@@
|
|
@@
|
|
(
|
|
- is_cache_unborn
|
|
+ is_index_unborn
|
|
|
|
|
- unmerged_cache
|
|
+ unmerged_index
|
|
|
|
|
- rename_cache_entry_at
|
|
+ rename_index_entry_at
|
|
|
|
|
- chmod_cache_entry
|
|
+ chmod_index_entry
|
|
|
|
|
- cache_file_exists
|
|
+ index_file_exists
|
|
|
|
|
- cache_name_is_other
|
|
+ index_name_is_other
|
|
|
|
|
- unmerge_cache_entry_at
|
|
+ unmerge_index_entry_at
|
|
|
|
|
- add_to_cache
|
|
+ add_to_index
|
|
|
|
|
- add_file_to_cache
|
|
+ add_file_to_index
|
|
|
|
|
- add_cache_entry
|
|
+ add_index_entry
|
|
|
|
|
- remove_file_from_cache
|
|
+ remove_file_from_index
|
|
|
|
|
- ce_match_stat
|
|
+ ie_match_stat
|
|
|
|
|
- ce_modified
|
|
+ ie_modified
|
|
|
|
|
- resolve_undo_clear
|
|
+ resolve_undo_clear_index
|
|
)
|
|
(
|
|
+ &the_index,
|
|
...)
|
|
|
|
@@
|
|
@@
|
|
(
|
|
- refresh_and_write_cache
|
|
+ repo_refresh_and_write_index
|
|
)
|
|
(
|
|
+ the_repository,
|
|
...
|
|
+ , NULL, NULL, NULL
|
|
)
|
|
|
|
// "the_index" special-cases
|
|
@@
|
|
@@
|
|
(
|
|
- read_cache_from
|
|
+ read_index_from
|
|
)
|
|
(
|
|
+ &the_index,
|
|
...
|
|
+ , get_git_dir()
|
|
)
|
|
|
|
@@
|
|
@@
|
|
(
|
|
- refresh_cache
|
|
+ refresh_index
|
|
)
|
|
(
|
|
+ &the_index,
|
|
...
|
|
+ , NULL, NULL, NULL
|
|
)
|