8aa38563b2
The update-index plumbing command had a hacky --unresolve implementation that was written back in the days when merge was the only way for users to end up with higher stages in the index, and assumed that stage #2 must have come from HEAD, stage #3 from MERGE_HEAD and didn't bother to compute the stage #1 information. There were several issues with this approach: - These days, merge is not the only command, and conflicts coming from commands like cherry-pick, "am -3", etc. cannot be recreated by looking at MERGE_HEAD; - For a conflict that came from a merge that had renames, picking up the same path from MERGE_HEAD and HEAD wouldn't help recreating it, either; - It may have been Ok not to recreate stage #1 back when it was written, because "diff --ours/--theirs" were the only availble ways to review conflicts and they don't need stage #1 information. "diff --cc" that was invented much later is a lot more useful way but it needs stage #1. We can use resolve-undo information recorded in the index extension to solve all of these issues. Signed-off-by: Junio C Hamano <gitster@pobox.com>
119 lines
2.6 KiB
Bash
Executable File
119 lines
2.6 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='undoing resolution'
|
|
|
|
. ./test-lib.sh
|
|
|
|
check_resolve_undo () {
|
|
msg=$1
|
|
shift
|
|
while case $# in
|
|
0) break ;;
|
|
1|2|3) die "Bug in check-resolve-undo test" ;;
|
|
esac
|
|
do
|
|
path=$1
|
|
shift
|
|
for stage in 1 2 3
|
|
do
|
|
sha1=$1
|
|
shift
|
|
case "$sha1" in
|
|
'') continue ;;
|
|
esac
|
|
sha1=$(git rev-parse --verify "$sha1")
|
|
printf "100644 %s %s\t%s\n" $sha1 $stage $path
|
|
done
|
|
done >"$msg.expect" &&
|
|
git ls-files --resolve-undo >"$msg.actual" &&
|
|
test_cmp "$msg.expect" "$msg.actual"
|
|
}
|
|
|
|
prime_resolve_undo () {
|
|
git reset --hard &&
|
|
git checkout second^0 &&
|
|
test_tick &&
|
|
test_must_fail git merge third^0 &&
|
|
echo merge does not leave anything &&
|
|
check_resolve_undo empty &&
|
|
echo different >file &&
|
|
git add file &&
|
|
echo resolving records &&
|
|
check_resolve_undo recorded file initial:file second:file third:file
|
|
}
|
|
|
|
test_expect_success setup '
|
|
test_commit initial file first &&
|
|
git branch side &&
|
|
git branch another &&
|
|
test_commit second file second &&
|
|
git checkout side &&
|
|
test_commit third file third &&
|
|
git checkout another &&
|
|
test_commit fourth file fourth &&
|
|
git checkout master
|
|
'
|
|
|
|
test_expect_success 'add records switch clears' '
|
|
prime_resolve_undo &&
|
|
test_tick &&
|
|
git commit -m merged &&
|
|
echo committing keeps &&
|
|
check_resolve_undo kept file initial:file second:file third:file &&
|
|
git checkout second^0 &&
|
|
echo switching clears &&
|
|
check_resolve_undo cleared
|
|
'
|
|
|
|
test_expect_success 'rm records reset clears' '
|
|
prime_resolve_undo &&
|
|
test_tick &&
|
|
git commit -m merged &&
|
|
echo committing keeps &&
|
|
check_resolve_undo kept file initial:file second:file third:file &&
|
|
|
|
echo merge clears upfront &&
|
|
test_must_fail git merge fourth^0 &&
|
|
check_resolve_undo nuked &&
|
|
|
|
git rm -f file &&
|
|
echo resolving records &&
|
|
check_resolve_undo recorded file initial:file HEAD:file fourth:file &&
|
|
|
|
git reset --hard &&
|
|
echo resetting discards &&
|
|
check_resolve_undo discarded
|
|
'
|
|
|
|
test_expect_success 'plumbing clears' '
|
|
prime_resolve_undo &&
|
|
test_tick &&
|
|
git commit -m merged &&
|
|
echo committing keeps &&
|
|
check_resolve_undo kept file initial:file second:file third:file &&
|
|
|
|
echo plumbing clear &&
|
|
git update-index --clear-resolve-undo &&
|
|
check_resolve_undo cleared
|
|
'
|
|
|
|
test_expect_success 'add records checkout -m undoes' '
|
|
prime_resolve_undo &&
|
|
git diff HEAD &&
|
|
git checkout --conflict=merge file &&
|
|
echo checkout used the record and removed it &&
|
|
check_resolve_undo removed &&
|
|
echo the index and the work tree is unmerged again &&
|
|
git diff >actual &&
|
|
grep "^++<<<<<<<" actual
|
|
'
|
|
|
|
test_expect_success 'unmerge with plumbing' '
|
|
prime_resolve_undo &&
|
|
git update-index --unresolve file &&
|
|
git ls-files -u >actual &&
|
|
test $(wc -l <actual) = 3
|
|
'
|
|
|
|
test_done
|