Junio C Hamano dad0b3d8e5 push: do not let configured foreign-vcs permanently clobbered ... Recently, 6f48d39 (clone: delay cloning until after remote HEAD checking, 2012-01-16) tried to record if a remote helper needs to be called after parsing the remote when transport_get() is called, by overwriting the field meant to store the configured remote helper name in the remote structure. This is OK when a remote represents a single remote repository, but fails miserably when pushing to locations with multiple URLs, like this: $ cat .git/config [remote "origin"] url = https://code.google.com/p/git-htmldocs/ url = github.com:gitster/git-htmldocs.git push = refs/heads/master:refs/heads/master $ git push The second url that is supposed to use the git-over-ssh transport mistakenly use https:// and fails with: error: Couldn't resolve host 'github.com:gitster' while accessing github.com:gitster/git-htmldocs.git/info/refs fatal: HTTP request failed The right solution would probably be to dedicate a separate field to store the detected external helper to be used, which is valid only during a single use of transport until it is disconnected, instead of overwriting foreign_vcs field, but in the meantime, this band-aid should suffice. Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2012-01-23 16:38:42 -08:00
..
add.c
annotate.c
apply.c	Merge branch 'bc/maint-apply-check-no-patch' into maint	2011-12-21 11:42:45 -08:00
archive.c
bisect--helper.c
blame.c
branch.c	Merge branch 'jn/branch-move-to-self' into maint	2011-12-28 11:32:33 -08:00
bundle.c
cat-file.c
check-attr.c
check-ref-format.c
checkout-index.c
checkout.c	clone: print advice on checking out detached HEAD	2012-01-16 16:26:27 -08:00
clean.c
clone.c	clone: print advice on checking out detached HEAD	2012-01-16 16:26:27 -08:00
commit-tree.c	Merge branch 'nd/war-on-nul-in-commit'	2011-12-22 11:27:26 -08:00
commit.c	Merge branch 'jk/maint-strbuf-missing-init' into maint	2011-12-28 11:42:46 -08:00
config.c	Merge branch 'jv/maint-config-set' into maint	2011-12-28 12:03:19 -08:00
count-objects.c
describe.c
diff-files.c
diff-index.c
diff-tree.c
diff.c
fast-export.c
fetch-pack.c
fetch.c
fmt-merge-msg.c
for-each-ref.c
fsck.c
gc.c
grep.c
hash-object.c
help.c
index-pack.c
init-db.c
log.c	Sync with v1.7.8.1	2011-12-21 12:02:44 -08:00
ls-files.c
ls-remote.c
ls-tree.c
mailinfo.c
mailsplit.c
merge-base.c
merge-file.c
merge-index.c
merge-ours.c
merge-recursive.c
merge-tree.c
merge.c	Merge branch 'jk/maint-strbuf-missing-init' into maint	2011-12-28 11:42:46 -08:00
mktag.c
mktree.c
mv.c	Merge branch 'jk/maint-mv' into maint	2011-12-28 11:32:36 -08:00
name-rev.c
notes.c	Merge branch 'nd/war-on-nul-in-commit'	2011-12-22 11:27:26 -08:00
pack-objects.c
pack-redundant.c
pack-refs.c
patch-id.c
prune-packed.c
prune.c
push.c	push: do not let configured foreign-vcs permanently clobbered	2012-01-23 16:38:42 -08:00
read-tree.c
receive-pack.c
reflog.c
remote-ext.c
remote-fd.c
remote.c
replace.c
rerere.c
reset.c
rev-list.c
rev-parse.c
revert.c	Merge branch 'rr/revert-cherry-pick'	2011-12-22 15:30:22 -08:00
rm.c
send-pack.c
shortlog.c
show-branch.c
show-ref.c
stripspace.c
symbolic-ref.c
tag.c
tar-tree.c
unpack-file.c
unpack-objects.c
update-index.c
update-ref.c
update-server-info.c
upload-archive.c
var.c
verify-pack.c
verify-tag.c
write-tree.c