undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
f1cd2d93c2
git-commit-vandalism/contrib/subtree
History
Luke Shumaker f1cd2d93c2 subtree: t7900: fix 'verify one file change per commit' 
As far as I can tell, this test isn't actually testing anything, because
someone forgot to tack on `--name-only` to `git log`.  This seems to
have been the case since the test was first written, back in fa16ab36ad
("test.sh: make sure no commit changes more than one file at a time.",
2009-04-26), unless `git log` used to do that by default and didn't need
the flag back then?

Convincing myself that it's not actually testing anything was tricky,
the code is a little hard to reason about.  It can be made a lot simpler
if instead of trying to parse all of the info from a single `git log`,
we're OK calling `git log` from inside of a loop.  And it's my opinion
that tests are not the place for clever optimized code.

So, fix and simplify the test, so that it's actually testing something
and is simpler to reason about.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-04-28 16:47:17 +09:00
..
t subtree: t7900: fix 'verify one file change per commit' 2021-04-28 16:47:17 +09:00
.gitignore subtree: add an install-html target 2014-10-15 15:17:08 -07:00
COPYING
git-subtree.sh contrib/subtree: ensure only one rev is provided 2019-03-12 17:38:03 +09:00
git-subtree.txt contrib/subtree: document 'push' does not take '--squash' 2020-08-18 12:12:29 -07:00
INSTALL Fix git-subtree install instructions 2012-04-09 22:26:19 -05:00
Makefile subtree: fix build with AsciiDoctor 2 2020-04-08 12:10:36 -07:00
README
todo contrib/subtree: remove "push" command from the "todo" file 2015-11-06 09:32:33 -08:00

README 

Please read git-subtree.txt for documentation.

Please don't contact me using github mail; it's slow, ugly, and worst of
all, redundant. Email me instead at apenwarr@gmail.com and I'll be happy to
help.

Avery