9ff2f06069
Make the replay_opts_release() function added in the preceding commit non-static, and use it for freeing the "struct replay_opts" constructed for "rebase" and "revert". To safely call our new replay_opts_release() we'll need to stop calling it in sequencer_remove_state(), and instead call it where we allocate the "struct replay_opts" itself. This is because in e.g. do_interactive_rebase() we construct a "struct replay_opts" with "get_replay_opts()", and then call "complete_action()". If we get far enough in that function without encountering errors we'll call "pick_commits()" which (indirectly) calls sequencer_remove_state() at the end. But if we encounter errors anywhere along the way we'd punt out early, and not free() the memory we allocated. Remembering whether we previously called sequencer_remove_state() would be a hassle. Using a FREE_AND_NULL() pattern would also work, as it would be safe to call replay_opts_release() repeatedly. But let's fix this properly instead, by having the owner of the data free() it. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
83 lines
1.5 KiB
Bash
Executable File
83 lines
1.5 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='test cherry-picking (and reverting) a root commit'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
echo first > file1 &&
|
|
git add file1 &&
|
|
test_tick &&
|
|
git commit -m "first" &&
|
|
|
|
git symbolic-ref HEAD refs/heads/second &&
|
|
rm .git/index file1 &&
|
|
echo second > file2 &&
|
|
git add file2 &&
|
|
test_tick &&
|
|
git commit -m "second" &&
|
|
|
|
git symbolic-ref HEAD refs/heads/third &&
|
|
rm .git/index file2 &&
|
|
echo third > file3 &&
|
|
git add file3 &&
|
|
test_tick &&
|
|
git commit -m "third"
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick a root commit' '
|
|
|
|
git checkout second^0 &&
|
|
git cherry-pick main &&
|
|
echo first >expect &&
|
|
test_cmp expect file1
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a root commit' '
|
|
|
|
git revert main &&
|
|
test_path_is_missing file1
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick a root commit with an external strategy' '
|
|
|
|
git cherry-pick --strategy=resolve main &&
|
|
echo first >expect &&
|
|
test_cmp expect file1
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a root commit with an external strategy' '
|
|
|
|
git revert --strategy=resolve main &&
|
|
test_path_is_missing file1
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick two root commits' '
|
|
|
|
echo first >expect.file1 &&
|
|
echo second >expect.file2 &&
|
|
echo third >expect.file3 &&
|
|
|
|
git checkout second^0 &&
|
|
git cherry-pick main third &&
|
|
|
|
test_cmp expect.file1 file1 &&
|
|
test_cmp expect.file2 file2 &&
|
|
test_cmp expect.file3 file3 &&
|
|
git rev-parse --verify HEAD^^ &&
|
|
test_must_fail git rev-parse --verify HEAD^^^
|
|
|
|
'
|
|
|
|
test_done
|