undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diff-delta: fix encoding size that would not fit in "unsigned int"

Browse Source 
The current delta code produces incorrect pack objects for files > 4GB,
because the size is copied from size_t field to "unsigned int" variables
during the encoding process.

Signed-off-by: Martin Koegler <martin.koegler@chello.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Martin Koegler 2017-08-10 09:01:01 +02:00 committed by Junio C Hamano
parent 4274c698f4
commit 3f0a67a1f6
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
diff-delta.c
View File

@ -319,7 +319,9 @@ create_delta(const struct delta_index *index,
const void *trg_buf, unsigned long trg_size,
unsigned long *delta_size, unsigned long max_size)
{
unsigned int i, outpos, outsize, moff, msize, val;
unsigned int i, val;
off_t outpos, moff;
size_t l, outsize, msize;
int inscnt;
const unsigned char *ref_data, *ref_top, *data, *top;
unsigned char *out;
@ -336,20 +338,20 @@ create_delta(const struct delta_index *index,
return NULL;
/* store reference buffer size */
i = index->src_size;
while (i >= 0x80) {
out[outpos++] = i | 0x80;
i >>= 7;
l = index->src_size;
while (l >= 0x80) {
out[outpos++] = l | 0x80;
l >>= 7;
}
out[outpos++] = i;
out[outpos++] = l;
/* store target buffer size */
i = trg_size;
while (i >= 0x80) {
out[outpos++] = i | 0x80;
i >>= 7;
l = trg_size;
while (l >= 0x80) {
out[outpos++] = l | 0x80;
l >>= 7;
}
out[outpos++] = i;
out[outpos++] = l;
ref_data = index->src_buf;
ref_top = ref_data + index->src_size;