undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] git-local-fetch: Fix error checking and leak in setup_indices()

Browse Source 
setup_indices() did not check the return value of opendir(), and
did not have a corresponding closedir() call.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Sergey Vlasov 2005-09-23 16:28:23 +04:00 committed by Junio C Hamano
parent d35bbe0b2e
commit 8be707de55
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
local-fetch.c
View File

@ -38,6 +38,8 @@ static int setup_indices(void)
unsigned char sha1[20]; unsigned char sha1[20];
sprintf(filename, "%s/objects/pack/", path); sprintf(filename, "%s/objects/pack/", path);
dir = opendir(filename); dir = opendir(filename);
if (!dir)
return -1;
while ((de = readdir(dir)) != NULL) { while ((de = readdir(dir)) != NULL) {
int namelen = strlen(de->d_name); int namelen = strlen(de->d_name);
if (namelen != 50 || if (namelen != 50 ||
@ -46,6 +48,7 @@ static int setup_indices(void)
get_sha1_hex(de->d_name + 5, sha1); get_sha1_hex(de->d_name + 5, sha1);
setup_index(sha1); setup_index(sha1);
} }
closedir(dir);
return 0; return 0;
} }