03267e8656
The read_cache() in prepare_to_commit() would end up clobbering the pointer we had for a previously populated "the_index.cache_tree" in the very common case of "git commit" stressed by e.g. the tests being changed here. We'd populate "the_index.cache_tree" by calling "update_main_cache_tree" in prepare_index(), but would not end up with a "fully prepared" index. What constitutes an existing index is clearly overly fuzzy, here we'll check "active_nr" (aka "the_index.cache_nr"), but our "the_index.cache_tree" might have been malloc()'d already. Thus the code added in11c8a74a64(commit: write cache-tree data when writing index anyway, 2011-12-06) would end up allocating the "cache_tree", and would interact here with code added in7168624c35(Do not generate full commit log message if it is not going to be used, 2007-11-28). The result was a very common memory leak. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>
57 lines
1.5 KiB
Bash
Executable File
57 lines
1.5 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='check that the most basic functions work
|
|
|
|
|
|
Verify wrappers and compatibility functions.
|
|
'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'character classes (isspace, isalpha etc.)' '
|
|
test-tool ctype
|
|
'
|
|
|
|
test_expect_success 'mktemp to nonexistent directory prints filename' '
|
|
test_must_fail test-tool mktemp doesnotexist/testXXXXXX 2>err &&
|
|
grep "doesnotexist/test" err
|
|
'
|
|
|
|
test_expect_success POSIXPERM,SANITY 'mktemp to unwritable directory prints filename' '
|
|
mkdir cannotwrite &&
|
|
test_when_finished "chmod +w cannotwrite" &&
|
|
chmod -w cannotwrite &&
|
|
test_must_fail test-tool mktemp cannotwrite/testXXXXXX 2>err &&
|
|
grep "cannotwrite/test" err
|
|
'
|
|
|
|
test_expect_success 'git_mkstemps_mode does not fail if fd 0 is not open' '
|
|
git commit --allow-empty -m message <&-
|
|
'
|
|
|
|
test_expect_success 'check for a bug in the regex routines' '
|
|
# if this test fails, re-build git with NO_REGEX=1
|
|
test-tool regex --bug
|
|
'
|
|
|
|
test_expect_success 'incomplete sideband messages are reassembled' '
|
|
test-tool pkt-line send-split-sideband >split-sideband &&
|
|
test-tool pkt-line receive-sideband <split-sideband 2>err &&
|
|
grep "Hello, world" err
|
|
'
|
|
|
|
test_expect_success 'eof on sideband message is reported' '
|
|
printf 1234 >input &&
|
|
test-tool pkt-line receive-sideband <input 2>err &&
|
|
test_i18ngrep "unexpected disconnect" err
|
|
'
|
|
|
|
test_expect_success 'missing sideband designator is reported' '
|
|
printf 0004 >input &&
|
|
test-tool pkt-line receive-sideband <input 2>err &&
|
|
test_i18ngrep "missing sideband" err
|
|
'
|
|
|
|
test_done
|